Re: [PATCH v6 10/12] drm/i915/psr: Add function for triggering "Frame Change" event

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Jan 27, 2025 at 12:28:44PM +0200, Jouni Högander wrote:
> Add new function to trigger "Frame Change" event for ensuring we are waking
> up before vblank evasion.
> 
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 22 ++++++++++++++++++++++
>  drivers/gpu/drm/i915/display/intel_psr.h |  3 +++
>  2 files changed, 25 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index c6712312a04d4..945cab1537732 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -44,6 +44,7 @@
>  #include "intel_psr.h"
>  #include "intel_psr_regs.h"
>  #include "intel_snps_phy.h"
> +#include "intel_vblank.h"
>  #include "skl_universal_plane.h"
>  
>  /**
> @@ -2289,6 +2290,27 @@ bool intel_psr_needs_block_dc_vblank(const struct intel_crtc_state *crtc_state)
>  	return false;
>  }
>  
> +/**
> + * intel_psr_trigger_frame_change_event - Trigger "Frame Change" event
> + * @state: the atomic state
> + * @dsb: DSB context
> + * @crtc: the CRTC
> + *
> + * Generate PSR "Frame Change" event.
> + */
> +void intel_psr_trigger_frame_change_event(struct intel_atomic_state *state,
> +					  struct intel_dsb *dsb,

IIRC I made the dsb the first parameter everywhere else.
We should try to be consistent about it.

With that
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> +					  struct intel_crtc *crtc)
> +{
> +	const struct intel_crtc_state *crtc_state =
> +		intel_pre_commit_crtc_state(state, crtc);
> +	struct intel_display *display = to_intel_display(crtc);
> +
> +	if (crtc_state->has_psr)
> +		intel_de_write_dsb(display, dsb,
> +				   CURSURFLIVE(display, crtc->pipe), 0);
> +}
> +
>  static u32 man_trk_ctl_enable_bit_get(struct intel_display *display)
>  {
>  	struct drm_i915_private *dev_priv = to_i915(display->drm);
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.h b/drivers/gpu/drm/i915/display/intel_psr.h
> index e6eba6633a92b..1cd9ab8aa6e81 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.h
> +++ b/drivers/gpu/drm/i915/display/intel_psr.h
> @@ -64,6 +64,9 @@ bool intel_psr_link_ok(struct intel_dp *intel_dp);
>  
>  void intel_psr_lock(const struct intel_crtc_state *crtc_state);
>  void intel_psr_unlock(const struct intel_crtc_state *crtc_state);
> +void intel_psr_trigger_frame_change_event(struct intel_atomic_state *state,
> +					  struct intel_dsb *dsb,
> +					  struct intel_crtc *crtc);
>  void intel_psr_connector_debugfs_add(struct intel_connector *connector);
>  void intel_psr_debugfs_register(struct intel_display *display);
>  
> -- 
> 2.43.0

-- 
Ville Syrjälä
Intel