Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Povilas Kanapickas <povilas@radix.lt>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH xf86-video-intel] meson: Add dependency on xv
Date: Mon, 10 Feb 2025 19:07:46 +0200	[thread overview]
Message-ID: <Z6oyYgCu06vs_Lhk@intel.com> (raw)
In-Reply-To: <77434761-e627-4a82-8482-34e6cce79349@radix.lt>

On Sat, Feb 08, 2025 at 12:24:26AM +0200, Povilas Kanapickas wrote:
> Symbols such as XvCreateImage, XvPutImage, XvGetPortAttribute come from
> libXv.so. Linking to this dependency directly fixes build errors on
> Debian Bookworm against xserver 21.1.

Thanks, pushed to master.

> ---
>  meson.build                      | 1 +
>  src/legacy/i810/xvmc/meson.build | 1 +
>  xvmc/meson.build                 | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index 227ca2eb..553902bb 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -157,6 +157,7 @@ endif
>  
>  with_xvmc = get_option('xvmc')
>  if with_xvmc
> +  dependency('xv', required : true)
>    dependency('xvmc', required : true)
>    dependency('dri2proto', required : true)
>    dependency('x11', required : true)
> diff --git a/src/legacy/i810/xvmc/meson.build b/src/legacy/i810/xvmc/meson.build
> index cd05f3ef..3505f15b 100644
> --- a/src/legacy/i810/xvmc/meson.build
> +++ b/src/legacy/i810/xvmc/meson.build
> @@ -4,6 +4,7 @@ shared_library('I810XvMC',
>  	       sources : 'I810XvMC.c',
>  	       dependencies : [
>  		 dependency('x11', required : true),
> +		 dependency('xv', required : true),
>  		 dependency('xvmc', required : true),
>  		 dependency('xorg-server', required : true),
>  		 dependency('libdrm', required : true),
> diff --git a/xvmc/meson.build b/xvmc/meson.build
> index 0ecc51e5..eeba2b66 100644
> --- a/xvmc/meson.build
> +++ b/xvmc/meson.build
> @@ -14,6 +14,7 @@ shared_library('IntelXvMC',
>  	       dependencies : [
>  		 dependency('threads', required : true),
>  		 dependency('x11', required : true),
> +		 dependency('xv', required : true),
>  		 dependency('xvmc', required : true),
>  		 dependency('xorg-server', required : true),
>  		 dependency('x11-xcb', required : true),
> -- 
> 2.39.5

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2025-02-10 17:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 22:24 [PATCH xf86-video-intel] meson: Add dependency on xv Povilas Kanapickas
2025-02-10 17:07 ` Ville Syrjälä [this message]
2025-02-10 18:19 ` ✗ Fi.CI.BUILD: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6oyYgCu06vs_Lhk@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=povilas@radix.lt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox