Re: [PATCH 11/11] drm/i915: Pimp the Y plane selection debugs

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Feb 12, 2025 at 10:39:20AM +0100, Maarten Lankhorst wrote:
> Hey,
> 
> Patch series looks good.
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> 
> One small comment, I've noticed that in 10/11 I still see a mention of 
> slave plane in the comments, it would probably be best to fixup any 
> mention to Y plane in the comments too.

Ack, I fixed those up and rebased+reposted the series
due to the earlier intel_display changes.

Thanks for the review.

> 
> Cheers,
> 
> ~Maarten
> 
> On 2025-01-27 18:21, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Use the standard [PLANE:%d:%s] stuff for the Y plane debugs,
> > and more clearly spell out which plane is UV plane and which
> > is Y plane when linking them.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >   drivers/gpu/drm/i915/display/intel_atomic_plane.c | 8 +++++---
> >   1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> > index 1fb35f4a7cf4..9c2e8aaba8cd 100644
> > --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> > +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> > @@ -1236,8 +1236,9 @@ static void link_nv12_planes(struct intel_crtc_state *crtc_state,
> >   	crtc_state->data_rate[y_plane->id] = crtc_state->data_rate_y[uv_plane->id];
> >   	crtc_state->rel_data_rate[y_plane->id] = crtc_state->rel_data_rate_y[uv_plane->id];
> >   
> > -	drm_dbg_kms(&dev_priv->drm, "Using %s as Y plane for %s\n",
> > -		    y_plane->base.name, uv_plane->base.name);
> > +	drm_dbg_kms(&dev_priv->drm, "UV plane [PLANE:%d:%s] using Y plane [PLANE:%d:%s]\n",
> > +		    uv_plane->base.base.id, uv_plane->base.name,
> > +		    y_plane->base.base.id, y_plane->base.name);
> >   
> >   	/* Copy parameters to Y plane */
> >   	intel_plane_copy_hw_state(y_plane_state, uv_plane_state);
> > @@ -1328,7 +1329,8 @@ static int icl_check_nv12_planes(struct intel_atomic_state *state,
> >   
> >   		if (!y_plane_state) {
> >   			drm_dbg_kms(&dev_priv->drm,
> > -				    "Need %d free Y planes for planar YUV\n",
> > +				    "[CRTC:%d:%s] need %d free Y planes for planar YUV\n",
> > +				    crtc->base.base.id, crtc->base.name,
> >   				    hweight8(crtc_state->nv12_planes));
> >   
> >   			return -EINVAL;

-- 
Ville Syrjälä
Intel