Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Tejas Upadhyay <tejas.upadhyay@intel.com>
Cc: Intel-GFX@lists.freedesktop.org
Subject: Re: [Intel-gfx] drm/i915/selftest: Remove avoidable init assignment
Date: Tue, 7 Mar 2023 08:36:55 -0500	[thread overview]
Message-ID: <ZAc998diJkqCJTz2@intel.com> (raw)
In-Reply-To: <20230307094643.532271-1-tejas.upadhyay@intel.com>

On Tue, Mar 07, 2023 at 03:16:43PM +0530, Tejas Upadhyay wrote:
> We can skip the assignment and i915 variable
> altogether and use refernce directly. Also used at
> single place only.
> 
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>

trusting the compiler,

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/selftests/i915_request.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index 7a27aba3da8a..a9b79888c193 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -1117,9 +1117,8 @@ static int live_empty_request(void *arg)
>  
>  static struct i915_vma *recursive_batch(struct intel_gt *gt)
>  {
> -	struct drm_i915_private *i915 = gt->i915;
>  	struct drm_i915_gem_object *obj;
> -	const int ver = GRAPHICS_VER(i915);
> +	const int ver = GRAPHICS_VER(gt->i915);
>  	struct i915_vma *vma;
>  	u32 *cmd;
>  	int err;
> -- 
> 2.25.1
> 

  parent reply	other threads:[~2023-03-07 13:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07  9:46 [Intel-gfx] drm/i915/selftest: Remove avoidable init assignment Tejas Upadhyay
2023-03-07 10:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-03-07 13:36 ` Rodrigo Vivi [this message]
2023-03-07 21:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAc998diJkqCJTz2@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=Intel-GFX@lists.freedesktop.org \
    --cc=tejas.upadhyay@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox