Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Andi Shyti <andi.shyti@kernel.org>,
	intel-gfx@lists.freedesktop.org,
	Jonathan Cavitt <jonathan.cavitt@intel.com>,
	dri-devel@lists.freedesktop.org,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Drop igt_cs_tlb
Date: Thu, 23 Mar 2023 14:35:17 +0100	[thread overview]
Message-ID: <ZBxVlflHfpvMcBmz@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230320192117.287374-1-andi.shyti@linux.intel.com>

Hi,

On Mon, Mar 20, 2023 at 08:21:17PM +0100, Andi Shyti wrote:
> From: Jonathan Cavitt <jonathan.cavitt@intel.com>
> 
> The gt_tlb live selftest has the same code coverage as the
> igt_cs_tlb subtest of gtt, except it is better at detecting
> TLB bugs.  Furthermore, while igt_cs_tlb is hitting some
> unforeseen issues, these issues are either false positives
> due to the test being poorly formatted, or are true
> positives that can be more easily diagnosed with smaller
> tests.  As such, igt_cs_tlb is superceded by and obsoleted
> by gt_tlb, meaning it can be removed.
> 
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Acked-by: Nirmoy Das <nirmoy.das@intel.com>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

This patch, anyway needs some follow up for adding the range
TLB invalidation part.

Andi

  parent reply	other threads:[~2023-03-23 13:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 19:21 [Intel-gfx] [PATCH] drm/i915/selftests: Drop igt_cs_tlb Andi Shyti
2023-03-21  6:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Drop igt_cs_tlb (rev3) Patchwork
2023-03-21  6:54 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-03-21  6:54 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2023-03-21  7:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-21 10:48 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-03-23 13:35 ` Andi Shyti [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-02-17 22:33 [Intel-gfx] [PATCH] drm/i915/selftests: Drop igt_cs_tlb Jonathan Cavitt
2023-02-22 15:18 ` Andrzej Hajda
2023-03-20 17:58 ` Das, Nirmoy
2023-02-17 17:20 Jonathan Cavitt
2023-02-17 22:15 ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBxVlflHfpvMcBmz@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=andrzej.hajda@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jonathan.cavitt@intel.com \
    --cc=nirmoy.das@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox