Re: [Intel-gfx] [Intel-xe] [PATCH v2 rebased 3/6] drm/i915: Only initialize dlk phy lock in display 12 and newer

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Apr 10, 2023 at 05:10:01PM +0000, Souza, Jose wrote:
> On Mon, 2023-04-10 at 11:37 -0400, Rodrigo Vivi wrote:
> > On Thu, Apr 06, 2023 at 07:31:30AM -0700, José Roberto de Souza wrote:
> > > This spin lock will not be used in older display versions, so no need
> > > to initialize it.
> > 
> > Should we add some warn_on(disp_ver < 12) on the dkl phy functions?
> 
> If called in platforms with display version older than 12 we will get warnings about spink lock functions being called in a non initialized spinlock_t
> anyways.

indeed! we are good then...

> 
> > 
> > Anyway:
> > 
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > 
> > 
> > > 
> > > Cc: intel-gfx@lists.freedesktop.org
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_dkl_phy.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_dkl_phy.c b/drivers/gpu/drm/i915/display/intel_dkl_phy.c
> > > index 5bce7b5b27bc7..1c5d410b74e5d 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_dkl_phy.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_dkl_phy.c
> > > @@ -108,5 +108,6 @@ intel_dkl_phy_posting_read(struct drm_i915_private *i915, struct intel_dkl_phy_r
> > >  void
> > >  intel_dkl_phy_init(struct drm_i915_private *i915)
> > >  {
> > > -	spin_lock_init(&i915->display.dkl.phy_lock);
> > > +	if (DISPLAY_VER(i915) >= 12)
> > > +		spin_lock_init(&i915->display.dkl.phy_lock);
> > >  }
> > > -- 
> > > 2.40.0
> > > 
>