Re: [Intel-gfx] [PATCH 0/2] Add support for dumping error captures via kernel logging

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Apr 10, 2023 at 12:25:21PM -0700, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
> 
> Sometimes, the only effective way to debug an issue is to dump all the
> interesting information at the point of failure. So add support for
> doing that.

No! Please no!
We have some of this on Xe and I'm hating it. I'm going to try to remove
from there soon. It is horrible when you lost the hability to use dmesg
directly because it goes over the number of lines it saves... or even
with dmesg -w it goes over the number of lines of your terminal...
or the ssh and serial slowness when printing a bunch of information.

We probably want to be able to capture multiple error states and be
able to cross them with a kernel timeline, but definitely not overflood
our log terminals.

> 
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> 
> 
> John Harrison (2):
>   drm/i915: Dump error capture to kernel log
>   drm/i915/guc: Dump error capture to dmesg on CTB error
> 
>  drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c |  53 +++++++++
>  drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h |   6 +
>  drivers/gpu/drm/i915/i915_gpu_error.c     | 130 ++++++++++++++++++++++
>  drivers/gpu/drm/i915/i915_gpu_error.h     |   8 ++
>  4 files changed, 197 insertions(+)
> 
> -- 
> 2.39.1
>