From: Andi Shyti <andi.shyti@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@kernel.org>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
DRI Devel <dri-devel@lists.freedesktop.org>,
Andi Shyti <andi.shyti@kernel.org>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/i915_drv: Use i915 instead of dev_priv insied the file_priv structure
Date: Fri, 21 Apr 2023 16:51:20 +0200 [thread overview]
Message-ID: <ZEKi6HrrVaOSVUv1@ashyti-mobl2.lan> (raw)
In-Reply-To: <ZEKYoMMtYRkngiIz@rdvivi-mobl4>
On Fri, Apr 21, 2023 at 10:07:28AM -0400, Rodrigo Vivi wrote:
> On Fri, Apr 21, 2023 at 03:46:54PM +0200, Andi Shyti wrote:
> > In the process of renaming all instances of 'dev_priv' to 'i915',
> > start using 'i915' within the 'drm_i915_file_private' structure.
>
> The patch looks good but the commit message seems off to me...
Will rephrase.
> One thing we need to take care with mass conversions of dev_priv
> to i915 is to ensure we are not converting the implicit declarations,
> since we want to kill that. But on a quick glance it looks fine.
>
> Did you generated this with full s/dev_priv/i915 in i915_drv.h?
Yes, I did such swap in i915_drv.h but I checked each line not to
break anything. In this file it's OK to do a /dev_priv/i915/
change.
It will be different with i915_irq.h where dev_priv is embedded
in the define.
I there is anything off it wouldn't have compiled and anyway,
CI will warn.
Thanks, Rodrigo!
Andi
next prev parent reply other threads:[~2023-04-21 14:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 13:46 [Intel-gfx] [PATCH 0/2] Use i915 instead of dev_priv Andi Shyti
2023-04-21 13:46 ` [Intel-gfx] [PATCH 1/2] drm/i915/i915_drv: Use proper parameter naming in for_each_gt() Andi Shyti
2023-04-21 14:00 ` Rodrigo Vivi
2023-04-21 14:05 ` Rodrigo Vivi
2023-04-21 14:37 ` Andi Shyti
2023-04-21 15:26 ` Andrzej Hajda
2023-04-21 13:46 ` [Intel-gfx] [PATCH 2/2] drm/i915/i915_drv: Use i915 instead of dev_priv insied the file_priv structure Andi Shyti
2023-04-21 14:07 ` Rodrigo Vivi
2023-04-21 14:51 ` Andi Shyti [this message]
2023-04-21 15:27 ` Andrzej Hajda
2023-04-21 15:19 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Use i915 instead of dev_priv Patchwork
2023-04-21 15:31 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-04-23 0:45 ` [Intel-gfx] [PATCH 0/2] " Andi Shyti
2023-04-24 10:38 ` Jani Nikula
2023-04-24 14:32 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEKi6HrrVaOSVUv1@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=rodrigo.vivi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox