Re: [Intel-gfx] [PATCH 04/24] drm/i915/vma: document struct i915_vma_resource wakeref member

[Rodrigo Vivi <rodrigo.vivi@kernel.org>]

On Tue, May 02, 2023 at 06:37:21PM +0300, Jani Nikula wrote:
> drivers/gpu/drm/i915/i915_vma_resource.h:129: warning: Function parameter or member 'wakeref' not described in 'i915_vma_resource'
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_vma_resource.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_vma_resource.h b/drivers/gpu/drm/i915/i915_vma_resource.h
> index c1864e3d0b43..2053c037dbfb 100644
> --- a/drivers/gpu/drm/i915/i915_vma_resource.h
> +++ b/drivers/gpu/drm/i915/i915_vma_resource.h
> @@ -47,6 +47,7 @@ struct i915_page_sizes {
>   * @chain: Pointer to struct i915_sw_fence used to await dependencies.
>   * @rb: Rb node for the vm's pending unbind interval tree.
>   * @__subtree_last: Interval tree private member.
> + * @wakeref: wakeref.

if all of these were near their declarations it wouldn't get missed.
But anyway, this is not part of this patch to move all of them, so


Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


>   * @vm: non-refcounted pointer to the vm. This is for internal use only and
>   * this member is cleared after vm_resource unbind.
>   * @mr: The memory region of the object pointed to by the vma.
> -- 
> 2.39.2
>