Re: [Intel-gfx] [PATCH 2/4] drm/i915: Record default rps threshold values

[Rodrigo Vivi <rodrigo.vivi@kernel.org>]

On Mon, May 22, 2023 at 12:59:26PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Record the default values as preparation for exposing the sysfs controls.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@kernel.org>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 +++
>  drivers/gpu/drm/i915/gt/intel_rps.c      | 2 ++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h b/drivers/gpu/drm/i915/gt/intel_gt_types.h
> index f08c2556aa25..1b22d7a50665 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_types.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_types.h
> @@ -83,6 +83,9 @@ enum intel_submission_method {
>  struct gt_defaults {
>  	u32 min_freq;
>  	u32 max_freq;
> +
> +	u8 rps_up_threshold;
> +	u8 rps_down_threshold;
>  };
>  
>  enum intel_gt_type {
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index 791097eb9bfd..333abc8f7ecb 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -2016,7 +2016,9 @@ void intel_rps_init(struct intel_rps *rps)
>  
>  	/* Set default thresholds in % */
>  	rps->power.up_threshold = 95;
> +	rps_to_gt(rps)->defaults.rps_up_threshold = rps->power.up_threshold;
>  	rps->power.down_threshold = 85;
> +	rps_to_gt(rps)->defaults.rps_down_threshold = rps->power.down_threshold;
>  
>  	/* Finally allow us to boost to max by default */
>  	rps->boost_freq = rps->max_freq;
> -- 
> 2.39.2
>