From: Dan Carpenter <dan.carpenter@linaro.org>
To: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
Daniel Vetter <daniel@ffwll.ch>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@gmail.com>
Subject: [Intel-gfx] [PATCH] drm/i915/gsc: Fix error code in intel_gsc_uc_heci_cmd_submit_nonpriv()
Date: Tue, 6 Jun 2023 11:22:07 +0300 [thread overview]
Message-ID: <ZH7sr+Vs4zOQoouU@moroto> (raw)
This should return negative -EAGAIN instead of positive EAGAIN.
Fixes: e5e1e6d28ebc ("drm/i915/pxp: Add MTL helpers to submit Heci-Cmd-Packet to GSC")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c b/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c
index 579c0f5a1438..42218ae6ef13 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_gsc_uc_heci_cmd_submit.c
@@ -202,7 +202,7 @@ intel_gsc_uc_heci_cmd_submit_nonpriv(struct intel_gsc_uc *gsc,
if (++trials < 10)
goto retry;
else
- err = EAGAIN;
+ err = -EAGAIN;
}
}
i915_gem_ww_ctx_fini(&ww);
--
2.30.2
next reply other threads:[~2023-06-06 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 8:22 Dan Carpenter [this message]
2023-06-06 9:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gsc: Fix error code in intel_gsc_uc_heci_cmd_submit_nonpriv() Patchwork
2023-06-06 18:07 ` [Intel-gfx] [PATCH] " Teres Alexis, Alan Previn
2023-06-06 18:32 ` Dan Carpenter
2023-06-07 18:44 ` Teres Alexis, Alan Previn
2023-06-08 8:37 ` Dan Carpenter
2023-06-08 18:49 ` Teres Alexis, Alan Previn
2023-06-07 0:39 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2023-06-08 0:10 ` [Intel-gfx] [PATCH] " Andi Shyti
2023-06-08 0:14 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH7sr+Vs4zOQoouU@moroto \
--to=dan.carpenter@linaro.org \
--cc=airlied@gmail.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox