From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Refine mmio debug flow to avoid bad unlock balance detected.
Date: Tue, 11 Jul 2023 13:06:03 +0200 [thread overview]
Message-ID: <ZK03m76B7LFaDszp@ashyti-mobl2.lan> (raw)
In-Reply-To: <87y1jmhgtd.fsf@intel.com>
Hi Jani,
> >> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> >> index 796ebfe6c550..9d665978cc43 100644
> >> --- a/drivers/gpu/drm/i915/intel_uncore.c
> >> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> >> @@ -1931,9 +1931,6 @@ unclaimed_reg_debug(struct intel_uncore *uncore,
> >> const bool read,
> >> const bool before)
> >> {
> >> - if (likely(!uncore->i915->params.mmio_debug) || !uncore->debug)
> >> - return;
> >> -
> >
> > this is a very good catch! I'm fine with the change from my side:
> >
> > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
>
> Nope, there's a bug in the patch.
>
> https://lore.kernel.org/r/87ilb00zot.fsf@intel.com
OK, I missed your reply.
Thanks, Jani!
Andi
prev parent reply other threads:[~2023-07-11 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 8:07 [Intel-gfx] [PATCH] drm/i915: Refine mmio debug flow to avoid bad unlock balance detected Lee Shawn C
2023-07-04 8:42 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2023-07-04 8:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-04 9:54 ` [Intel-gfx] [PATCH] " Jani Nikula
2023-07-04 11:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2023-07-11 10:31 ` [Intel-gfx] [PATCH] " Andi Shyti
2023-07-11 10:40 ` Jani Nikula
2023-07-11 11:06 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK03m76B7LFaDszp@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox