From: Jason Gunthorpe <jgg@nvidia.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>
Cc: "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"Hao, Xudong" <xudong.hao@intel.com>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"Xu, Terrence" <terrence.xu@intel.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"lulu@redhat.com" <lulu@redhat.com>,
"Jiang, Yanting" <yanting.jiang@intel.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"Zhao, Yan Y" <yan.y.zhao@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
"clegoate@redhat.com" <clegoate@redhat.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>
Subject: Re: [Intel-gfx] [PATCH v14 22/26] vfio: Add VFIO_DEVICE_BIND_IOMMUFD
Date: Sat, 15 Jul 2023 10:04:51 -0300 [thread overview]
Message-ID: <ZLKZc/wnMbrp9ZYE@nvidia.com> (raw)
In-Reply-To: <DS0PR11MB75297BF68F3FAD4B9EEA483AC335A@DS0PR11MB7529.namprd11.prod.outlook.com>
On Sat, Jul 15, 2023 at 04:16:52AM +0000, Liu, Yi L wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Friday, July 14, 2023 10:42 PM
> >
> > On Mon, Jul 10, 2023 at 07:59:24PM -0700, Yi Liu wrote:
> >
> > > +static inline long vfio_df_ioctl_bind_iommufd(struct vfio_device_file *df,
> > > + struct vfio_device_bind_iommufd __user
> > *arg)
> > > +{
> > > + return -EOPNOTSUPP;
> > > +}
> >
> > This should be -ENOTTY
>
> Okay. Since there are quite a few stub functions in the drivers/vfio/vfio.h.
> Let me check the rule. All the stub functions should return -ENOTTY in
> the !IS_ENABLED(CONFIG_XXX) case, if the function returns int., is
> it?
No, just ioctl returns ENOTTY, so really just this function.
Jason
next prev parent reply other threads:[~2023-07-15 13:04 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 2:59 [Intel-gfx] [PATCH v14 00/26] Add vfio_device cdev for iommufd support Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 01/26] vfio: Allocate per device file structure Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 02/26] vfio: Refine vfio file kAPIs for KVM Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 03/26] vfio: Accept vfio device file in the KVM facing kAPI Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 04/26] kvm/vfio: Prepare for accepting vfio device fd Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 05/26] kvm/vfio: Accept vfio device file from userspace Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 06/26] vfio: Pass struct vfio_device_file * to vfio_device_open/close() Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 07/26] vfio: Block device access via device fd until device is opened Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 08/26] vfio: Add cdev_device_open_cnt to vfio_group Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 09/26] vfio: Make vfio_df_open() single open for device cdev path Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 10/26] vfio-iommufd: Move noiommu compat validation out of vfio_iommufd_bind() Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 11/26] vfio-iommufd: Split bind/attach into two steps Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 12/26] vfio: Record devid in vfio_device_file Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 13/26] vfio-iommufd: Add detach_ioas support for physical VFIO devices Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 14/26] iommufd/device: Add iommufd_access_detach() API Yi Liu
2023-07-14 13:54 ` Jason Gunthorpe
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 15/26] vfio-iommufd: Add detach_ioas support for emulated VFIO devices Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 16/26] vfio: Move vfio_device_group_unregister() to be the first operation in unregister Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 17/26] vfio: Move device_del() before waiting for the last vfio_device registration refcount Yi Liu
2023-07-14 13:56 ` Jason Gunthorpe
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 18/26] vfio: Add cdev for vfio_device Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 19/26] vfio: Test kvm pointer in _vfio_device_get_kvm_safe() Yi Liu
2023-07-14 14:11 ` Jason Gunthorpe
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 20/26] iommufd: Add iommufd_ctx_from_fd() Yi Liu
2023-07-14 14:20 ` Jason Gunthorpe
2023-07-15 4:10 ` Liu, Yi L
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 21/26] vfio: Avoid repeated user pointer cast in vfio_device_fops_unl_ioctl() Yi Liu
2023-07-14 14:27 ` Jason Gunthorpe
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 22/26] vfio: Add VFIO_DEVICE_BIND_IOMMUFD Yi Liu
2023-07-14 14:42 ` Jason Gunthorpe
2023-07-15 4:16 ` Liu, Yi L
2023-07-15 13:04 ` Jason Gunthorpe [this message]
2023-07-15 14:19 ` Liu, Yi L
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 23/26] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT Yi Liu
2023-07-14 14:50 ` Jason Gunthorpe
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 24/26] vfio: Move the IOMMU_CAP_CACHE_COHERENCY check in __vfio_register_dev() Yi Liu
2023-07-14 15:14 ` Jason Gunthorpe
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 25/26] vfio: Compile vfio_group infrastructure optionally Yi Liu
2023-07-11 2:59 ` [Intel-gfx] [PATCH v14 26/26] docs: vfio: Add vfio device cdev description Yi Liu
2023-07-14 15:19 ` Jason Gunthorpe
2023-07-11 3:47 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev18) Patchwork
2023-07-25 5:37 ` [Intel-gfx] [PATCH v14 00/26] Add vfio_device cdev for iommufd support Jiang, Yanting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLKZc/wnMbrp9ZYE@nvidia.com \
--to=jgg@nvidia.com \
--cc=chao.p.peng@linux.intel.com \
--cc=clegoate@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jasowang@redhat.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=terrence.xu@intel.com \
--cc=xudong.hao@intel.com \
--cc=yan.y.zhao@intel.com \
--cc=yanting.jiang@intel.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox