From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: mjrosato@linux.ibm.com, jasowang@redhat.com,
xudong.hao@intel.com, zhenzhong.duan@intel.com,
peterx@redhat.com, terrence.xu@intel.com,
chao.p.peng@linux.intel.com, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, lulu@redhat.com, yanting.jiang@intel.com,
joro@8bytes.org, nicolinc@nvidia.com, kevin.tian@intel.com,
yan.y.zhao@intel.com, intel-gfx@lists.freedesktop.org,
eric.auger@redhat.com, intel-gvt-dev@lists.freedesktop.org,
yi.y.sun@linux.intel.com, clegoate@redhat.com, cohuck@redhat.com,
shameerali.kolothum.thodi@huawei.com,
suravee.suthikulpanit@amd.com, robin.murphy@arm.com
Subject: Re: [Intel-gfx] [PATCH v10 09/10] vfio/pci: Copy hot-reset device info to userspace in the devices loop
Date: Tue, 18 Jul 2023 13:54:30 -0300 [thread overview]
Message-ID: <ZLbDxktjv9fjrT5p@nvidia.com> (raw)
In-Reply-To: <20230718105542.4138-10-yi.l.liu@intel.com>
On Tue, Jul 18, 2023 at 03:55:41AM -0700, Yi Liu wrote:
> This copies the vfio_pci_dependent_device to userspace during looping each
> affected device for reporting vfio_pci_hot_reset_info. This avoids counting
> the affected devices and allocating a potential large buffer to store the
> vfio_pci_dependent_device of all the affected devices before copying them
> to userspace.
>
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Tested-by: Yanting Jiang <yanting.jiang@intel.com>
> Tested-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
> drivers/vfio/pci/vfio_pci_core.c | 93 ++++++++++++--------------------
> 1 file changed, 33 insertions(+), 60 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2023-07-18 16:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 10:55 [Intel-gfx] [PATCH v10 00/10] Enhance vfio PCI hot reset for vfio cdev device Yi Liu
2023-07-18 10:55 ` [Intel-gfx] [PATCH v10 01/10] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset() Yi Liu
2023-07-18 10:55 ` [Intel-gfx] [PATCH v10 02/10] vfio/pci: Move the existing hot reset logic to be a helper Yi Liu
2023-07-18 10:55 ` [Intel-gfx] [PATCH v10 03/10] iommufd: Reserve all negative IDs in the iommufd xarray Yi Liu
2023-07-18 10:55 ` [Intel-gfx] [PATCH v10 04/10] iommufd: Add iommufd_ctx_has_group() Yi Liu
2023-07-18 10:55 ` [Intel-gfx] [PATCH v10 05/10] iommufd: Add helper to retrieve iommufd_ctx and devid Yi Liu
2023-07-18 10:55 ` [Intel-gfx] [PATCH v10 06/10] vfio: Mark cdev usage in vfio_device Yi Liu
2023-07-18 10:55 ` [Intel-gfx] [PATCH v10 07/10] vfio: Add helper to search vfio_device in a dev_set Yi Liu
2023-07-18 10:55 ` [Intel-gfx] [PATCH v10 08/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev Yi Liu
2023-07-18 10:55 ` [Intel-gfx] [PATCH v10 09/10] vfio/pci: Copy hot-reset device info to userspace in the devices loop Yi Liu
2023-07-18 16:54 ` Jason Gunthorpe [this message]
2023-07-18 10:55 ` [Intel-gfx] [PATCH v10 10/10] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET Yi Liu
2023-07-18 11:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enhance vfio PCI hot reset for vfio cdev device (rev10) Patchwork
2023-07-18 11:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-07-18 15:16 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLbDxktjv9fjrT5p@nvidia.com \
--to=jgg@nvidia.com \
--cc=chao.p.peng@linux.intel.com \
--cc=clegoate@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jasowang@redhat.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=terrence.xu@intel.com \
--cc=xudong.hao@intel.com \
--cc=yan.y.zhao@intel.com \
--cc=yanting.jiang@intel.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox