From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: michal.winiarski@intel.com, matthew.d.roper@intel.com,
intel-gfx@lists.freedesktop.org, saurabhg.gupta@intel.com,
chris.p.wilson@linux.intel.com, nirmoy.das@intel.com
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: Align igt_spinner_create_request with hangcheck
Date: Wed, 16 Aug 2023 22:56:12 +0200 [thread overview]
Message-ID: <ZN037CXaHe+tQil+@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230815165345.964068-2-jonathan.cavitt@intel.com>
Hi Jonathan,
On Tue, Aug 15, 2023 at 09:53:44AM -0700, Jonathan Cavitt wrote:
> Align igt_spinner_create_request with the hang_create_request
> implementation in selftest_hangcheck.c.
>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Acked-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
> ---
> drivers/gpu/drm/i915/selftests/igt_spinner.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/selftests/igt_spinner.c b/drivers/gpu/drm/i915/selftests/igt_spinner.c
> index 0f064930ef11..8c3e1f20e5a1 100644
> --- a/drivers/gpu/drm/i915/selftests/igt_spinner.c
> +++ b/drivers/gpu/drm/i915/selftests/igt_spinner.c
> @@ -179,6 +179,9 @@ igt_spinner_create_request(struct igt_spinner *spin,
>
> *batch++ = arbitration_command;
>
> + memset32(batch, MI_NOOP, 128);
> + batch += 128;
> +
> if (GRAPHICS_VER(rq->i915) >= 8)
> *batch++ = MI_BATCH_BUFFER_START | BIT(8) | 1;
> else if (IS_HASWELL(rq->i915))
> --
> 2.25.1
next prev parent reply other threads:[~2023-08-16 20:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 16:53 [Intel-gfx] [PATCH 0/2] drm/i915/selftests: Align igt_spinner_create_request with hangcheck Jonathan Cavitt
2023-08-15 16:53 ` [Intel-gfx] [PATCH 1/2] " Jonathan Cavitt
2023-08-15 19:28 ` Matt Roper
2023-08-16 20:33 ` Cavitt, Jonathan
2023-08-16 21:00 ` Matt Roper
2023-08-16 20:56 ` Andi Shyti [this message]
2023-08-15 16:53 ` [Intel-gfx] [PATCH 2/2] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner Jonathan Cavitt
2023-08-15 18:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Align igt_spinner_create_request with hangcheck Patchwork
2023-08-15 18:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-08-15 18:56 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN037CXaHe+tQil+@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=michal.winiarski@intel.com \
--cc=nirmoy.das@intel.com \
--cc=saurabhg.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox