Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: intel-gfx@lists.freedesktop.org, chris.p.wilson@linux.intel.com
Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915/gt: Wait longer for tasks in migrate selftest
Date: Thu, 31 Aug 2023 20:18:35 +0200	[thread overview]
Message-ID: <ZPDZexRdUjkh1DfF@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230828192852.2894671-2-jonathan.cavitt@intel.com>

Hi Jonathan,

On Mon, Aug 28, 2023 at 12:28:52PM -0700, Jonathan Cavitt wrote:
> The thread_global_copy subtest of the live migrate selftest creates a
> large number of threads and waits 10ms for them all to start.  This is
> not enough time to wait for the threaded tasks to start, as some may
> need to wait for additional ring space to be granted.  Threads that do
> so are at risk of getting stopped (signaled) in the middle of waiting
> for additional space, which can result in ERESTARTSYS getting reported
> erroneously by i915_request_wait.
> 
> Instead of waiting a flat 10ms for the threads to start, wait 10ms per
> thread.  This grants enough of a buffer for each thread to wait for
> additional ring space when needed.
> 
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>

Applied to drm-intel-gt-next.

Thanks,
Andi

  parent reply	other threads:[~2023-08-31 18:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 19:28 [Intel-gfx] [PATCH 0/1] drm/i915/gt: Wait longer for tasks in migrate selftest Jonathan Cavitt
2023-08-28 19:28 ` [Intel-gfx] [PATCH 1/1] " Jonathan Cavitt
2023-08-31 15:01   ` Andi Shyti
2023-08-31 18:18   ` Andi Shyti [this message]
2023-08-28 20:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-08-29 11:06   ` Andi Shyti
2023-08-29 16:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Wait longer for tasks in migrate selftest (rev2) Patchwork
2023-08-29 23:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPDZexRdUjkh1DfF@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=chris.p.wilson@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jonathan.cavitt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox