Re: [Intel-gfx] [PATCH] drm/i915/mtl: Drop force_probe requirement

[Andi Shyti <andi.shyti@linux.intel.com>]

Hi Radhakrishna,

On Tue, Sep 05, 2023 at 12:36:24PM -0700, Radhakrishna Sripada wrote:
> Meteorlake has been very usable for a while now, all of uapi changes
> related to fundamental platform usage have been finalized and all
> required firmware blobs are available. Recent CI results have also
> been healthy, so we're ready to drop the force_probe requirement and
> enable the platform by default.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>

Please keep me in the loop as well... It's been a year I've been
working for this patch to work :)

> ---
>  drivers/gpu/drm/i915/i915_pci.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index df7c261410f7..fe748906c06f 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -836,7 +836,6 @@ static const struct intel_device_info mtl_info = {
>  	.has_pxp = 1,
>  	.memory_regions = REGION_SMEM | REGION_STOLEN_LMEM,
>  	.platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(CCS0),
> -	.require_force_probe = 1,

What's the thinking behind this patch? Are you trying to
understand how CI behaves?

Andi

>  	MTL_CACHELEVEL,
>  };
>  
> -- 
> 2.34.1