From: Andi Shyti <andi.shyti@linux.intel.com>
To: Nirmoy Das <nirmoy.das@intel.com>
Cc: chris.p.wilson@linux.intel.com, intel-gfx@lists.freedesktop.org,
matthew.d.roper@intel.com
Subject: Re: [Intel-gfx] [PATCH 3/5] drm/i915: Implement __for_each_sgt_daddr_next
Date: Thu, 7 Sep 2023 15:46:41 +0200 [thread overview]
Message-ID: <ZPnUQbPNpQ8ZuUqy@ashyti-mobl2.lan> (raw)
In-Reply-To: <20230906113121.30472-4-nirmoy.das@intel.com>
[...]
> +/**
> + * __for_each_daddr_next - iterates over the device addresses with pre-initialized iterator.
> + * @__dp: Device address (output)
> + * @__iter: 'struct sgt_iter' (iterator state, external)
> + * @__step: step size
> + */
> +#define __for_each_daddr_next(__dp, __iter, __step) \
normally iter is the last parameter, but this is similar to other
for_each's...
nor r-b'eing this yet as there is a comment coming in the next
patch.
Andi
> + for (; ((__dp) = (__iter).dma + (__iter).curr), (__iter).sgp; \
> + (((__iter).curr += (__step)) >= (__iter).max) ? \
> + (__iter) = __sgt_iter(__sg_next((__iter).sgp), true), 0 : 0)
>
> /**
> * for_each_sgt_page - iterate over the pages of the given sg_table
> --
> 2.41.0
next prev parent reply other threads:[~2023-09-07 14:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 11:31 [Intel-gfx] [PATCH 0/5] Update GGTT with MI_UPDATE_GTT on MTL Nirmoy Das
2023-09-06 11:31 ` [Intel-gfx] [PATCH 1/5] drm/i915: Lift runtime-pm acquire callbacks out of intel_wakeref.mutex Nirmoy Das
2023-09-07 11:03 ` Andi Shyti
2023-09-06 11:31 ` [Intel-gfx] [PATCH 2/5] drm/i915: Create a kernel context for GGTT updates Nirmoy Das
2023-09-07 13:41 ` Andi Shyti
2023-09-13 12:05 ` Nirmoy Das
2023-09-06 11:31 ` [Intel-gfx] [PATCH 3/5] drm/i915: Implement __for_each_sgt_daddr_next Nirmoy Das
2023-09-07 13:46 ` Andi Shyti [this message]
2023-09-06 11:31 ` [Intel-gfx] [PATCH 4/5] drm/i915: Implement GGTT update method with MI_UPDATE_GTT Nirmoy Das
2023-09-07 13:48 ` Andi Shyti
2023-09-13 12:07 ` Nirmoy Das
2023-09-06 11:31 ` [Intel-gfx] [PATCH 5/5] drm/i915: Enable GGTT updates with binder in MTL Nirmoy Das
2023-09-06 12:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Update GGTT with MI_UPDATE_GTT on MTL Patchwork
2023-09-06 12:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-06 12:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-07 11:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Update GGTT with MI_UPDATE_GTT on MTL (rev2) Patchwork
2023-09-07 11:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-07 11:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-07 13:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-12 18:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Update GGTT with MI_UPDATE_GTT on MTL (rev3) Patchwork
2023-09-12 18:38 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-12 18:57 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPnUQbPNpQ8ZuUqy@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox