Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Drop Wa_14017240301
Date: Thu, 7 Sep 2023 09:50:50 -0400	[thread overview]
Message-ID: <ZPnVOrqXkS00feK2@intel.com> (raw)
In-Reply-To: <20230907000354.3729827-2-matthew.d.roper@intel.com>

On Wed, Sep 06, 2023 at 05:03:55PM -0700, Matt Roper wrote:
> Drop Wa_14017240301, which is only relevant to pre-production MTL
> hardware.  Although we usually wait a little bit longer to start
> dropping pre-production workarounds for a platform, it was suggested to
> eliminate this one slightly earlier because it's a bit unusual/ugly:
> this workaround is a display-specific workaround that requires matching
> on the graphics/GT IP version instead of the display IP version.
> 
> Suggested-by: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index 517df2aa7a91..007a0bcb3f93 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -2170,11 +2170,6 @@ skl_plane_disable_flip_done(struct intel_plane *plane)
>  static bool skl_plane_has_rc_ccs(struct drm_i915_private *i915,
>  				 enum pipe pipe, enum plane_id plane_id)
>  {
> -	/* Wa_14017240301 */
> -	if (IS_GFX_GT_IP_STEP(to_gt(i915), IP_VER(12, 70), STEP_A0, STEP_B0) ||
> -	    IS_GFX_GT_IP_STEP(to_gt(i915), IP_VER(12, 71), STEP_A0, STEP_B0))
> -		return false;
> -
>  	/* Wa_22011186057 */
>  	if (IS_ALDERLAKE_P(i915) && IS_DISPLAY_STEP(i915, STEP_A0, STEP_B0))
>  		return false;
> -- 
> 2.41.0
> 

  parent reply	other threads:[~2023-09-07 14:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07  0:03 [Intel-gfx] [PATCH] drm/i915/mtl: Drop Wa_14017240301 Matt Roper
2023-09-07  1:08 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-09-07 13:50 ` Rodrigo Vivi [this message]
2023-09-07 19:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Drop Wa_14017240301 (rev2) Patchwork
2023-09-07 22:42 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-07 23:31   ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPnVOrqXkS00feK2@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox