From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/dpt: replace GEM_BUG_ON() with drm_WARN_ON()
Date: Thu, 14 Sep 2023 08:41:22 -0400 [thread overview]
Message-ID: <ZQL/ctvik2oJDns7@intel.com> (raw)
In-Reply-To: <17e70eaf967bdfe99111cdbb3bcf6aa2f0b0e837.1694684044.git.jani.nikula@intel.com>
On Thu, Sep 14, 2023 at 12:34:59PM +0300, Jani Nikula wrote:
> Avoid using GEM_BUG_ON() in display code.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dpt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dpt.c b/drivers/gpu/drm/i915/display/intel_dpt.c
> index fbfd8f959f17..48582b31b7f7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpt.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpt.c
> @@ -29,7 +29,7 @@ static inline struct i915_dpt *
> i915_vm_to_dpt(struct i915_address_space *vm)
> {
> BUILD_BUG_ON(offsetof(struct i915_dpt, vm));
> - GEM_BUG_ON(!i915_is_dpt(vm));
> + drm_WARN_ON(&vm->i915->drm, !i915_is_dpt(vm));
> return container_of(vm, struct i915_dpt, vm);
> }
>
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-09-14 12:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 9:34 [Intel-gfx] [PATCH 0/3] drm/i915/display: remove last uses of GEM_BUG_ON/GEM_WARN_ON Jani Nikula
2023-09-14 9:34 ` [Intel-gfx] [PATCH 1/3] drm/i915/fbc: replace GEM_BUG_ON() to drm_WARN_ON() Jani Nikula
2023-09-14 12:40 ` Rodrigo Vivi
2023-09-15 15:28 ` Jani Nikula
2023-09-14 9:34 ` [Intel-gfx] [PATCH 2/3] drm/i915/fb: replace GEM_WARN_ON() with drm_WARN_ON() Jani Nikula
2023-09-14 12:41 ` Rodrigo Vivi
2023-09-14 9:34 ` [Intel-gfx] [PATCH 3/3] drm/i915/dpt: replace GEM_BUG_ON() " Jani Nikula
2023-09-14 12:41 ` Rodrigo Vivi [this message]
2023-09-14 16:48 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: remove last uses of GEM_BUG_ON/GEM_WARN_ON Patchwork
2023-09-14 17:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-14 21:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQL/ctvik2oJDns7@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox