From: Matthew Wilcox <willy@infradead.org>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Panic in gen8_ggtt_insert_entries() with v6.5
Date: Tue, 19 Sep 2023 17:23:51 +0100 [thread overview]
Message-ID: <ZQnLF91vi1w2n1vG@casper.infradead.org> (raw)
In-Reply-To: <169513996676.3667.11418695108092348576@emeril.freedesktop.org>
On Tue, Sep 19, 2023 at 04:12:46PM -0000, Patchwork wrote:
> -:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #7:
> > Andrzej asked me to try to revert commits 0b62af28f249, e0b72c14d8dc and 1e0877d58b1e, and reverting those fixed the i915 crash for me. The e0b72c14d8dc and 1e0877d58b1e commits look like just prerequisites, so I assume 0b62af28f249 ("i915: convert shmem_sg_free_table() to use a folio_batch") is the culprit here.
This is just a parsing fail.
> -:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
> #48: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:155:
> + nr_pages = min_t(unsigned long,
> + folio_nr_pages(folio), page_count - i);
This is bullshit. Aligning to open paren is an antipattern that leads
to significant unnecessary code churn. I will not be part of such a
stupid system.
next prev parent reply other threads:[~2023-09-19 16:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 16:14 [Intel-gfx] [REGRESSION] Panic in gen8_ggtt_insert_entries() with v6.5 Oleksandr Natalenko
2023-09-19 8:26 ` [Intel-gfx] [REGRESSION] [BISECTED] " Oleksandr Natalenko
2023-09-19 13:23 ` Oleksandr Natalenko
2023-09-19 14:03 ` Bagas Sanjaya
2023-09-19 14:14 ` Oleksandr Natalenko
2023-09-19 15:43 ` Matthew Wilcox
2023-09-19 16:02 ` Matthew Wilcox
2023-09-19 18:11 ` Oleksandr Natalenko
2023-09-19 19:15 ` Matthew Wilcox
2023-09-19 14:08 ` [Intel-gfx] [REGRESSION] " Bagas Sanjaya
2023-09-29 13:45 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-09-19 16:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-09-19 16:23 ` Matthew Wilcox [this message]
2023-09-19 16:12 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-19 16:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQnLF91vi1w2n1vG@casper.infradead.org \
--to=willy@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox