From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Set min/max to expected values
Date: Wed, 20 Sep 2023 10:07:18 -0400 [thread overview]
Message-ID: <ZQr8lowFNiMGnrbn@intel.com> (raw)
In-Reply-To: <20230918190259.2817143-1-vinay.belgaumkar@intel.com>
On Mon, Sep 18, 2023 at 12:02:59PM -0700, Vinay Belgaumkar wrote:
> A prior(rps) test leaves the system in a bad state causing failures
> in the basic test.
Why?
What was the freq immediately before the failure that made the
machine to be busted and not accept the new freq request?
Maybe we should use this information to limit the freq requests
that we accept instead of workaround the test case. Otherwise
we are at risk of users selecting the bad freq that let " the
system in a bad state"...
> Set min/max to expected values before running it.
> Test will restore values at the end.
>
> Link: https://gitlab.freedesktop.org/drm/intel/-/issues/8670
>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
> tests/intel/i915_pm_freq_api.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/i915_pm_freq_api.c b/tests/intel/i915_pm_freq_api.c
> index 03bd0d05b..6018692a2 100644
> --- a/tests/intel/i915_pm_freq_api.c
> +++ b/tests/intel/i915_pm_freq_api.c
> @@ -55,7 +55,11 @@ static void test_freq_basic_api(int dirfd, int gt)
> rpn = get_freq(dirfd, RPS_RPn_FREQ_MHZ);
> rp0 = get_freq(dirfd, RPS_RP0_FREQ_MHZ);
> rpe = get_freq(dirfd, RPS_RP1_FREQ_MHZ);
> - igt_debug("GT: %d, RPn: %d, RPe: %d, RP0: %d", gt, rpn, rpe, rp0);
> + igt_debug("GT: %d, RPn: %d, RPe: %d, RP0: %d\n", gt, rpn, rpe, rp0);
> +
> + /* Set min/max to RPn, RP0 for baseline behavior */
> + igt_assert(set_freq(dirfd, RPS_MIN_FREQ_MHZ, rpn) > 0);
> + igt_assert(set_freq(dirfd, RPS_MAX_FREQ_MHZ, rp0) > 0);
>
> /*
> * Negative bound tests
> @@ -170,7 +174,7 @@ igt_main
> for_each_sysfs_gt_dirfd(i915, dirfd, gt) {
> stash_min[gt] = get_freq(dirfd, RPS_MIN_FREQ_MHZ);
> stash_max[gt] = get_freq(dirfd, RPS_MAX_FREQ_MHZ);
> - igt_debug("GT: %d, min: %d, max: %d", gt, stash_min[gt], stash_max[gt]);
> + igt_debug("GT: %d, min: %d, max: %d\n", gt, stash_min[gt], stash_max[gt]);
> igt_pm_ignore_slpc_efficient_freq(i915, dirfd, true);
> }
> igt_install_exit_handler(restore_sysfs_freq);
> --
> 2.38.1
>
next prev parent reply other threads:[~2023-09-20 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 19:02 [Intel-gfx] [PATCH i-g-t] tests/i915_pm_freq_api: Set min/max to expected values Vinay Belgaumkar
2023-09-20 14:04 ` [Intel-gfx] [igt-dev] " Riana Tauro
2023-09-20 14:07 ` Rodrigo Vivi [this message]
2023-09-20 16:18 ` [Intel-gfx] " Belgaumkar, Vinay
2023-09-20 20:33 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQr8lowFNiMGnrbn@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox