From: Andi Shyti <andi.shyti@linux.intel.com>
To: John.C.Harrison@intel.com
Cc: Intel-GFX@lists.freedesktop.org, DRI-Devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: More use of GT specific print helpers
Date: Mon, 9 Oct 2023 21:54:17 +0200 [thread overview]
Message-ID: <ZSRaaVzpL51DA3y+@ashyti-mobl2.lan> (raw)
In-Reply-To: <20231009183802.673882-3-John.C.Harrison@Intel.com>
Hi John,
...
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -71,6 +71,7 @@
> #include "gem/i915_gem_pm.h"
> #include "gt/intel_gt.h"
> #include "gt/intel_gt_pm.h"
> +#include "gt/intel_gt_print.h"
> #include "gt/intel_rc6.h"
>
> #include "pxp/intel_pxp.h"
> @@ -429,7 +430,7 @@ static int i915_pcode_init(struct drm_i915_private *i915)
> for_each_gt(gt, i915, id) {
> ret = intel_pcode_init(gt->uncore);
> if (ret) {
> - drm_err(>->i915->drm, "gt%d: intel_pcode_init failed %d\n", id, ret);
> + gt_err(gt, "intel_pcode_init failed %d\n", ret);
using gt_*() print functions in the upper layers looks a bit
wrong to me. If we need GT printing, the prints need to be done
inside the function called, in this case would be
intel_pcode_init().
Andi
next prev parent reply other threads:[~2023-10-09 19:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 18:38 [Intel-gfx] [PATCH 0/2] More print message helper updates John.C.Harrison
2023-10-09 18:38 ` [Intel-gfx] [PATCH 1/2] drm/i915/gt: More use of GT specific print helpers John.C.Harrison
2023-10-09 19:50 ` Andi Shyti
2023-10-09 19:54 ` John Harrison
2023-10-09 20:02 ` Andi Shyti
2023-10-09 20:17 ` John Harrison
2023-10-09 18:38 ` [Intel-gfx] [PATCH 2/2] drm/i915: " John.C.Harrison
2023-10-09 19:54 ` Andi Shyti [this message]
2023-10-09 19:57 ` John Harrison
2023-10-10 20:22 ` Andi Shyti
2023-10-10 2:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More print message helper updates Patchwork
2023-10-10 2:08 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-10 2:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-10-10 18:31 ` John Harrison
2023-10-10 5:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More print message helper updates (rev2) Patchwork
2023-10-10 5:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-10 5:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-10 11:36 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-10 18:29 ` John Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSRaaVzpL51DA3y+@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=DRI-Devel@lists.freedesktop.org \
--cc=Intel-GFX@lists.freedesktop.org \
--cc=John.C.Harrison@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox