From: Andi Shyti <andi.shyti@linux.intel.com>
To: John Harrison <john.c.harrison@intel.com>
Cc: janusz.krzysztofik@intel.com, matthew.d.roper@intel.com,
intel-gfx@lists.freedesktop.org,
Jonathan Cavitt <jonathan.cavitt@intel.com>,
saurabhg.gupta@intel.com, chris.p.wilson@linux.intel.com,
nirmoy.das@intel.com
Subject: Re: [Intel-gfx] [PATCH v13 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines
Date: Fri, 13 Oct 2023 12:37:38 +0200 [thread overview]
Message-ID: <ZSkd8m9xIbWESqRj@ashyti-mobl2.lan> (raw)
In-Reply-To: <b40599f6-1808-44e0-88c0-0b7ff30ed74d@intel.com>
Hi John,
...
> > static void guc_ggtt_invalidate(struct i915_ggtt *ggtt)
> > {
> > struct drm_i915_private *i915 = ggtt->vm.i915;
> > + struct intel_gt *gt;
> > - gen8_ggtt_invalidate(ggtt);
> > -
> > - if (GRAPHICS_VER(i915) >= 12) {
> > - struct intel_gt *gt;
> > + if (!HAS_GUC_TLB_INVALIDATION(i915))
> > + gen8_ggtt_invalidate(ggtt);
> This has not changed? As per comments from Matthew Roper and Nirmoy Das,
> there needs to be a fixup patch first to stop gen8_ggtt_invalidate() from
> being called on invalid platforms.
Nirmoy has been working on this, meantime.
https://patchwork.freedesktop.org/series/125111/
Andi
next prev parent reply other threads:[~2023-10-13 10:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 22:38 [Intel-gfx] [PATCH v13 0/7] drm/i915: Define and use GuC and CTB TLB invalidation routines Jonathan Cavitt
2023-10-12 22:38 ` [Intel-gfx] [PATCH v13 1/7] drm/i915: Add GuC TLB Invalidation device info flags Jonathan Cavitt
2023-10-12 22:38 ` [Intel-gfx] [PATCH v13 2/7] drm/i915/guc: Add CT size delay helper Jonathan Cavitt
2023-10-12 22:38 ` [Intel-gfx] [PATCH v13 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines Jonathan Cavitt
2023-10-13 1:10 ` John Harrison
2023-10-13 10:37 ` Andi Shyti [this message]
2023-10-13 14:52 ` Cavitt, Jonathan
2023-10-13 19:05 ` John Harrison
2023-10-12 22:38 ` [Intel-gfx] [PATCH v13 4/7] drm/i915: No TLB invalidation on suspended GT Jonathan Cavitt
2023-10-13 1:08 ` John Harrison
2023-10-13 10:49 ` Andi Shyti
2023-10-13 14:42 ` Cavitt, Jonathan
2023-10-13 19:12 ` John Harrison
2023-10-13 19:14 ` John Harrison
2023-10-12 22:38 ` [Intel-gfx] [PATCH v13 5/7] drm/i915: No TLB invalidation on wedged GT Jonathan Cavitt
2023-10-12 22:38 ` [Intel-gfx] [PATCH v13 6/7] drm/i915/gt: Increase sleep in gt_tlb selftest sanitycheck Jonathan Cavitt
2023-10-12 22:38 ` [Intel-gfx] [PATCH v13 7/7] drm/i915: Enable GuC TLB invalidations for MTL Jonathan Cavitt
2023-10-13 8:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Define and use GuC and CTB TLB invalidation routines Patchwork
2023-10-13 8:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-13 8:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-14 8:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSkd8m9xIbWESqRj@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=janusz.krzysztofik@intel.com \
--cc=john.c.harrison@intel.com \
--cc=jonathan.cavitt@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=nirmoy.das@intel.com \
--cc=saurabhg.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox