Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check if pmu is closed before stopping event

[Andi Shyti <andi.shyti@linux.intel.com>]

Hi Umesh,

On Thu, Oct 19, 2023 at 11:28:36AM -0700, Umesh Nerlige Ramappa wrote:
> When the driver unbinds, pmu is unregistered and i915->uabi_engines is
> set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine
> events, it issues a warn_on because engine lookup fails.
> 
> All perf hooks are taking care of this using a pmu->closed flag that is
> set when PMU unregisters. The stop event seems to have been left out.
> 
> Check for pmu->closed in pmu_event_stop as well.
> 
> Based on discussion here -
> https://patchwork.freedesktop.org/patch/492079/?series=105790&rev=2
> 
> v2: s/is/if/ in commit title

Please, next time version your patches. This is the third time
you send this, but there is only one 'v2' changelog.

> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

With Tvrtko's tags:

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Andi