From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v4] drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence
Date: Mon, 6 Nov 2023 22:06:46 +0200 [thread overview]
Message-ID: <ZUlHVorO6cqHOVRi@intel.com> (raw)
In-Reply-To: <20231031084557.1181630-1-jouni.hogander@intel.com>
On Tue, Oct 31, 2023 at 10:45:57AM +0200, Jouni Högander wrote:
> intel_atomic_commit_tail(state);
> }
>
> -static int
> -intel_atomic_commit_ready(struct i915_sw_fence *fence,
> - enum i915_sw_fence_notify notify)
> -{
> - struct intel_atomic_state *state =
> - container_of(fence, struct intel_atomic_state, commit_ready);
> -
> - switch (notify) {
> - case FENCE_COMPLETE:
> - /* we do blocking waits in the worker, nothing to do here */
> - break;
> - case FENCE_FREE:
> - {
> - struct drm_i915_private *i915 = to_i915(state->base.dev);
> - struct intel_atomic_helper *helper =
> - &i915->display.atomic_helper;
> -
> - if (llist_add(&state->freed, &helper->free_list))
> - queue_work(i915->unordered_wq, &helper->free_work);
BTW looks like we're left with a bunch of dead code
around this free_list stuff...
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2023-11-06 20:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 8:45 [Intel-gfx] [PATCH v4] drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence Jouni Högander
2023-10-31 10:05 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence (rev4) Patchwork
2023-10-31 19:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence (rev5) Patchwork
2023-11-02 8:29 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-11-02 8:55 ` [Intel-gfx] [PATCH v4] drm/i915/display: Use dma_fence interfaces instead of i915_sw_fence Hogander, Jouni
2023-11-06 20:06 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUlHVorO6cqHOVRi@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox