Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: use PIPE_CONF_CHECK_BOOL() for bool members

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Nov 29, 2023 at 07:33:16PM +0200, Jani Nikula wrote:
> Don't treat bools as integers.
> 
> v2: Rebase
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 9dc22fc8b3d3..d62cdae7ab6b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -5091,8 +5091,8 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
>  #define PIPE_CONF_QUIRK(quirk) \
>  	((current_config->quirks | pipe_config->quirks) & (quirk))
>  
> -	PIPE_CONF_CHECK_I(hw.enable);
> -	PIPE_CONF_CHECK_I(hw.active);
> +	PIPE_CONF_CHECK_BOOL(hw.enable);
> +	PIPE_CONF_CHECK_BOOL(hw.active);
>  
>  	PIPE_CONF_CHECK_I(cpu_transcoder);
>  	PIPE_CONF_CHECK_I(mst_master_transcoder);
> @@ -5301,8 +5301,8 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
>  	PIPE_CONF_CHECK_I(dsc.config.second_line_bpg_offset);
>  	PIPE_CONF_CHECK_I(dsc.config.nsl_bpg_offset);
>  
> -	PIPE_CONF_CHECK_I(dsc.compression_enable);
> -	PIPE_CONF_CHECK_I(dsc.dsc_split);
> +	PIPE_CONF_CHECK_BOOL(dsc.compression_enable);
> +	PIPE_CONF_CHECK_BOOL(dsc.dsc_split);
>  	PIPE_CONF_CHECK_I(dsc.compressed_bpp_x16);
>  
>  	PIPE_CONF_CHECK_BOOL(splitter.enable);
> -- 
> 2.39.2
>