From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/display: No need for full modeset due to psr
Date: Wed, 10 Jan 2024 14:54:11 +0200 [thread overview]
Message-ID: <ZZ6Tc94c9dV2g+vA@intel.com> (raw)
In-Reply-To: <20240109100517.1947414-2-jouni.hogander@intel.com>
On Tue, Jan 09, 2024 at 12:05:16PM +0200, Jouni Högander wrote:
> There is no specific reason to force full modeset if psr is enabled.
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> Tested-by: Paz Zcharya <pazz@chromium.org>
Reviewed-by: Stanislav Lisovskiy <staniskav.lisovskiy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 7 -------
> drivers/gpu/drm/i915/display/intel_dp.c | 7 -------
> 2 files changed, 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 31a6a82c1261..0cccf6df6718 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -5202,13 +5202,6 @@ intel_pipe_config_compare(const struct intel_crtc_state *current_config,
>
> PIPE_CONF_CHECK_CSC(csc);
> PIPE_CONF_CHECK_CSC(output_csc);
> -
> - if (current_config->active_planes) {
> - PIPE_CONF_CHECK_BOOL(has_psr);
> - PIPE_CONF_CHECK_BOOL(has_psr2);
> - PIPE_CONF_CHECK_BOOL(enable_psr2_sel_fetch);
> - PIPE_CONF_CHECK_I(dc3co_exitline);
> - }
> }
>
> PIPE_CONF_CHECK_BOOL(double_wide);
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 7e4b7d5606d4..ab415f41924d 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3326,13 +3326,6 @@ bool intel_dp_initial_fastset_check(struct intel_encoder *encoder,
> fastset = false;
> }
>
> - if (CAN_PSR(intel_dp)) {
> - drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] Forcing full modeset to compute PSR state\n",
> - encoder->base.base.id, encoder->base.name);
> - crtc_state->uapi.mode_changed = true;
> - fastset = false;
> - }
> -
> return fastset;
> }
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-01-10 12:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 10:05 [PATCH 0/2] Allow PSR mode changes without full modeset Jouni Högander
2024-01-09 10:05 ` [PATCH 1/2] drm/i915/display: No need for full modeset due to psr Jouni Högander
2024-01-10 12:54 ` Lisovskiy, Stanislav [this message]
2024-01-09 10:05 ` [PATCH 2/2] drm/i915/psr: CAN_PSR and CAN_PANEL_REPLAY can be now local defines Jouni Högander
2024-01-10 12:55 ` Lisovskiy, Stanislav
2024-01-15 5:57 ` Hogander, Jouni
2024-01-09 13:09 ` ✗ Fi.CI.CHECKPATCH: warning for Allow PSR mode changes without full modeset Patchwork
2024-01-09 13:20 ` ✓ Fi.CI.BAT: success " Patchwork
2024-01-09 15:22 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-01-12 11:54 ` Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZ6Tc94c9dV2g+vA@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox