From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: don't capture DERRMR for VLV/CHV
Date: Fri, 11 Apr 2025 10:15:46 +0300 [thread overview]
Message-ID: <Z_jBomYm-sqPpzjX@intel.com> (raw)
In-Reply-To: <20250411070823.230909-1-jani.nikula@intel.com>
On Fri, Apr 11, 2025 at 10:08:23AM +0300, Jani Nikula wrote:
> DERRMR isn't valid for VLV/CHV. Don't capture it for them.
>
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c b/drivers/gpu/drm/i915/display/intel_display_irq.c
> index f5dc050a6344..5d07b6a9e59e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_irq.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_irq.c
> @@ -2343,7 +2343,7 @@ intel_display_irq_snapshot_capture(struct intel_display *display)
> if (!snapshot)
> return NULL;
>
> - if (DISPLAY_VER(display) >= 6 && DISPLAY_VER(display) < 20)
> + if (DISPLAY_VER(display) >= 6 && DISPLAY_VER(display) < 20 && !HAS_GMCH(display))
> snapshot->derrmr = intel_de_read(display, DERRMR);
>
> return snapshot;
> --
> 2.39.5
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2025-04-11 7:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 14:23 [PATCH v2 0/5] drm/i915: error capture cleanups and refactor Jani Nikula
2025-04-09 14:23 ` [PATCH v2 1/5] drm/i915: use 32-bit access for gen2 irq registers Jani Nikula
2025-04-10 16:13 ` Ville Syrjälä
2025-04-09 14:23 ` [PATCH v2 2/5] drm/i915: record GEN2_IER in gtier[0] for pre-ilk error capture Jani Nikula
2025-04-10 16:15 ` Ville Syrjälä
2025-04-09 14:23 ` [PATCH v2 3/5] drm/i915: stop recording IER in " Jani Nikula
2025-04-10 16:16 ` Ville Syrjälä
2025-04-09 14:23 ` [PATCH v2 4/5] drm/i915: use display snapshot mechanism for display irq regs Jani Nikula
2025-04-10 16:26 ` Ville Syrjälä
2025-04-11 7:09 ` [PATCH v3] " Jani Nikula
2025-04-09 14:23 ` [PATCH v2 5/5] drm/i915: use graphics version instead of PCH split in error capture Jani Nikula
2025-04-11 9:45 ` Jani Nikula
2025-04-11 13:39 ` Ville Syrjälä
2025-04-09 14:59 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: error capture cleanups and refactor Patchwork
2025-04-09 14:59 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-04-09 15:24 ` ✓ i915.CI.BAT: success " Patchwork
2025-04-09 23:37 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-11 7:08 ` [PATCH] drm/i915: don't capture DERRMR for VLV/CHV Jani Nikula
2025-04-11 7:15 ` Ville Syrjälä [this message]
2025-04-11 9:00 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: don't capture DERRMR for VLV/CHV (rev2) Patchwork
2025-04-11 9:00 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-04-11 9:27 ` ✓ i915.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_jBomYm-sqPpzjX@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox