Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 4/5] drm/i915: Drop dead code for pvc
Date: Mon, 11 Mar 2024 12:22:02 -0400	[thread overview]
Message-ID: <Ze8vqnQemP5-ouI3@intel.com> (raw)
In-Reply-To: <xzrhpvzuah3cgghbbbhrjwesgtvotlipracgjcvcn3deiae74v@dnyojvaqtsii>

On Mon, Mar 11, 2024 at 10:35:20AM -0500, Lucas De Marchi wrote:
> On Mon, Mar 11, 2024 at 11:29:31AM -0400, Rodrigo Vivi wrote:
> > > @@ -2907,9 +2829,7 @@ engine_init_workarounds(struct intel_engine_cs *engine, struct i915_wa_list *wal
> > >  	if (engine->flags & I915_ENGINE_FIRST_RENDER_COMPUTE)
> > >  		general_render_compute_wa_init(engine, wal);
> > > 
> > > -	if (engine->class == COMPUTE_CLASS)
> > > -		ccs_engine_wa_init(engine, wal);
> > > -	else if (engine->class == RENDER_CLASS)
> > 
> > I don't believe we need to remove this chunk since we are not deleting the ccs_engine_wa_init.
> > If we want to keep that as a placeholder we should also keep the caller as well.
> 
> right... I had removed it but brought it back since I noticed the
> kernel-doc mentions and forgot to bring back the caller too. I will fix
> this in next rev.

thanks!
with that:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> 
> 
> thanks
> Lucas De Marchi

  reply	other threads:[~2024-03-11 16:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 19:36 [PATCH 0/5] drm/i915: cleanup dead code Lucas De Marchi
2024-03-06 19:36 ` [PATCH 1/5] drm/i915: Drop WA 16015675438 Lucas De Marchi
2024-03-12 22:54   ` Matt Roper
2024-03-12 23:47     ` Lucas De Marchi
2024-03-06 19:36 ` [PATCH 2/5] drm/i915: Drop dead code for xehpsdv Lucas De Marchi
2024-03-11 15:16   ` Rodrigo Vivi
2024-03-12 16:29     ` Lucas De Marchi
2024-03-12 22:58   ` Matt Roper
2024-03-12 23:07     ` Lucas De Marchi
2024-03-06 19:36 ` [PATCH 3/5] drm/i915: Update IP_VER(12, 50) Lucas De Marchi
2024-03-11 15:18   ` Rodrigo Vivi
2024-03-11 15:29     ` Lucas De Marchi
2024-03-11 16:21       ` Rodrigo Vivi
2024-03-06 19:36 ` [PATCH 4/5] drm/i915: Drop dead code for pvc Lucas De Marchi
2024-03-11 15:29   ` Rodrigo Vivi
2024-03-11 15:35     ` Lucas De Marchi
2024-03-11 16:22       ` Rodrigo Vivi [this message]
2024-03-06 19:36 ` [PATCH 5/5] drm/i915: Remove special handling for !RCS_MASK() Lucas De Marchi
2024-03-07  2:37 ` ✗ Fi.CI.SPARSE: warning for drm/i915: cleanup dead code Patchwork
2024-03-07  2:56 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-03-11 17:43 ` [PATCH 0/5] " Tvrtko Ursulin
2024-03-11 19:27   ` Lucas De Marchi
2024-03-12  9:54     ` Tvrtko Ursulin
2024-03-12 12:53       ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ze8vqnQemP5-ouI3@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox