Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "José Relvas" <josemonsantorelvas@gmail.com>
To: intel-gfx@lists.freedesktop.org
Subject: [REQUEST] Add support for Intel DPST (Display Power Saving Technology)
Date: Fri, 5 Apr 2024 14:58:41 +0100	[thread overview]
Message-ID: <ZhADkdyItNEuoxKN@aquecedor-3-0.lan> (raw)

Hey folks,

I've noticed that power-profiles-daemon recently added support for AMD's panel power saving technology with this MR:
https://gitlab.freedesktop.org/upower/power-profiles-daemon/-/merge_requests/137

It appears to be controlled via a panel_power_saving SYSFS property.

This reminded that Intel has a similar technology. RPL's datasheets confirm this:
https://edc.intel.com/content/www/us/en/design/products/platforms/details/raptor-lake-s/13th-generation-core-processors-datasheet-volume-1-of-2/display-power-savings-technologies/

> The Intel® DPST technique achieves back-light power savings while maintaining
> a good visual experience. This is accomplished by adaptively enhancing the
> displayed image while decreasing the back-light brightness simultaneously. 
> The goal of this technique is to provide equivalent end-user-perceived 
> image quality at a decreased back-light power level. 

> Intel® OPST solution uses same HW infrastructure as Intel® DPST. Frames are 
> processed using frame change threshold based interrupt mechanism similar
> to Intel® DPST. Intel® OPST SW algorithm determines which pixels in the 
> frame should be dimmed to save power keeping visual quality (such as contrast, color) 
> impact to acceptable level. Since there is no backlight for OLED panels,
> the power savings come solely from pixel dimming. 

However, it doesn't seem like i915 has any support for this. Searching online was
ineffective too:

- I found mentions of /sys/class/drm/card0/power/i915_dpst, but it doesn't seem to exist,
at least not anymore.

- A i915.dpst parameter was also brought up, but it doesn't seem to exist either.

Interestingly, all mentions of dpst on Linux were referring to Android, so maybe
this was a downstream thing with Android?

In any case, I found this email in the archive which confirms
that DPST was not supported (at least in 2012):
https://lore.kernel.org/intel-gfx/50ADFFB3.8030907@linux.intel.com/

Since AMD's equivalent to DPST is now supported by their driver and being used by userspace,
it seems like a sensible idea to implement this for i915. I've confirmed that this feature
has existed since (at least) Haswell (released over a decade ago!) so implementing it
would likely net a few energy consumption improvements for a large chunk of Intel laptops.

The best approach here would probably be to expose a similar attribute to amdgpu's 
"panel_power_savings", with a scale that controls the feature's aggressiveness,
then update userspace tools, including power-profiles-daemon, to set the value
based on the intended energy scheme.

Thanks for reading,
José Relvas

             reply	other threads:[~2024-04-08 14:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05 13:58 José Relvas [this message]
2024-04-16  8:00 ` [REQUEST] Add support for Intel DPST (Display Power Saving Technology) Jani Nikula
2024-04-16  9:41   ` José Relvas
2024-04-16 12:41     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhADkdyItNEuoxKN@aquecedor-3-0.lan \
    --to=josemonsantorelvas@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox