Re: [PATCH 01/10] drm/i915/display: move params copy at probe earlier

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, May 22, 2024 at 08:33:38PM +0300, Jani Nikula wrote:
> Copy the parameters earlier to make subsequent changes easier.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index cf093bc0cb28..9edadc7270f6 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -936,6 +936,8 @@ void intel_display_device_probe(struct drm_i915_private *i915)
>  	/* Add drm device backpointer as early as possible. */
>  	i915->display.drm = &i915->drm;
>  
> +	intel_display_params_copy(&i915->display.params);
> +
>  	if (HAS_GMD_ID(i915))
>  		info = probe_gmdid_display(i915, &ver, &rel, &step);
>  	else
> @@ -952,8 +954,6 @@ void intel_display_device_probe(struct drm_i915_private *i915)
>  		DISPLAY_RUNTIME_INFO(i915)->ip.rel = rel;
>  		DISPLAY_RUNTIME_INFO(i915)->ip.step = step;
>  	}
> -
> -	intel_display_params_copy(&i915->display.params);

I confess I got lost on the macros there. But from what I could
see, none of the things in between these 2 points would change
anything related to the params that are getting copied here.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

>  }
>  
>  void intel_display_device_remove(struct drm_i915_private *i915)
> -- 
> 2.39.2
>