From: Andi Shyti <andi.shyti@linux.intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
drm-devel@ashyti-mobl2.lan, Andi Shyti <andi.shyti@kernel.org>,
Chris Wilson <chris.p.wilson@linux.intel.com>,
Gnattu OC <gnattuoc@me.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Matt Roper <matthew.d.roper@intel.com>,
Jian Ye <jian.ye@intel.com>
Subject: Re: [PATCH] drm/i915/gt: Fix CCS id's calculation for CCS mode setting
Date: Fri, 17 May 2024 12:34:29 +0200 [thread overview]
Message-ID: <ZkcytdBIXEbL3GcV@ashyti-mobl2.lan> (raw)
In-Reply-To: <20240517090616.242529-1-andi.shyti@linux.intel.com>
Hi,
On Fri, May 17, 2024 at 11:06:16AM +0200, Andi Shyti wrote:
> The whole point of the previous fixes has been to change the CCS
> hardware configuration to generate only one stream available to
> the compute users. We did this by changing the info.engine_mask
> that is set during device probe, reset during the detection of
> the fused engines, and finally reset again when choosing the CCS
> mode.
>
> We can't use the engine_mask variable anymore, as with the
> current configuration, it imposes only one CCS no matter what the
> hardware configuration is.
>
> Before changing the engine_mask for the third time, save it and
> use it for calculating the CCS mode.
>
> After the previous changes, the user reported a performance drop
> to around 1/4. We have tested that the compute operations, with
> the current patch, have improved by the same factor.
>
> Fixes: 6db31251bb26 ("drm/i915/gt: Enable only one CCS for compute workload")
> Cc: Chris Wilson <chris.p.wilson@linux.intel.com>
> Cc: Gnattu OC <gnattuoc@me.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Tested-by: Jian Ye <jian.ye@intel.com>
of course:
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
next prev parent reply other threads:[~2024-05-17 10:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 9:06 [PATCH] drm/i915/gt: Fix CCS id's calculation for CCS mode setting Andi Shyti
2024-05-17 9:32 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-05-17 9:32 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-17 10:16 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-17 10:34 ` Andi Shyti [this message]
2024-05-17 14:34 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-17 20:43 ` [PATCH] " Umesh Nerlige Ramappa
2024-05-19 15:34 ` Gnattu OC
2024-05-21 22:25 ` ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Fix CCS id's calculation for CCS mode setting (rev2) Patchwork
2024-05-21 22:42 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-05-22 0:26 ` ✓ Fi.CI.BAT: success for drm/i915/gt: Fix CCS id's calculation for CCS mode setting (rev3) Patchwork
2024-05-22 0:26 ` ✗ Fi.CI.SPARSE: warning " Patchwork
2024-05-22 8:51 ` [PATCH] drm/i915/gt: Fix CCS id's calculation for CCS mode setting Andi Shyti
2024-05-22 13:12 ` ✗ Fi.CI.IGT: failure for drm/i915/gt: Fix CCS id's calculation for CCS mode setting (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkcytdBIXEbL3GcV@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=chris.p.wilson@linux.intel.com \
--cc=drm-devel@ashyti-mobl2.lan \
--cc=gnattuoc@me.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jian.ye@intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox