public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>,
	<intel-xe@lists.freedesktop.org>, <lucas.demarchi@intel.com>
Subject: Re: [PATCH 02/10] drm/i915/display: include gt/intel_gt_types.h where needed
Date: Fri, 31 May 2024 07:05:18 -0400	[thread overview]
Message-ID: <Zlmu7iU9ofl9sodB@intel.com> (raw)
In-Reply-To: <df73c0934ad21f157714a41b33b81cebd2a523a6.1717004739.git.jani.nikula@intel.com>

On Wed, May 29, 2024 at 08:48:06PM +0300, Jani Nikula wrote:
> Include what you use. We need to move the compat intel_gt_types.h under
> gt subdir.

ditto

> With this, we can drop the include from xe compat i915_drv.h.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_fbc.c                         | 1 +
>  drivers/gpu/drm/xe/compat-i915-headers/{ => gt}/intel_gt_types.h | 0
>  drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h                | 1 -
>  3 files changed, 1 insertion(+), 1 deletion(-)
>  rename drivers/gpu/drm/xe/compat-i915-headers/{ => gt}/intel_gt_types.h (100%)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 6985abeb6102..8e956e7a1964 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -44,6 +44,7 @@
>  #include <drm/drm_fourcc.h>
>  
>  #include "gem/i915_gem_stolen.h"
> +#include "gt/intel_gt_types.h"
>  #include "i915_drv.h"
>  #include "i915_reg.h"
>  #include "i915_utils.h"
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/intel_gt_types.h b/drivers/gpu/drm/xe/compat-i915-headers/gt/intel_gt_types.h
> similarity index 100%
> rename from drivers/gpu/drm/xe/compat-i915-headers/intel_gt_types.h
> rename to drivers/gpu/drm/xe/compat-i915-headers/gt/intel_gt_types.h
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> index 3be3d419530a..fb784ab64cd4 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> @@ -22,7 +22,6 @@
>  #include "i915_gpu_error.h"
>  #include "i915_reg_defs.h"
>  #include "i915_utils.h"
> -#include "intel_gt_types.h"
>  #include "intel_step.h"
>  #include "intel_uncore.h"
>  #include "intel_runtime_pm.h"
> -- 
> 2.39.2
> 

  reply	other threads:[~2024-05-31 11:05 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-29 17:48 [PATCH 00/10] drm/i915 and drm/xe display and compat cleanups Jani Nikula
2024-05-29 17:48 ` [PATCH 01/10] drm/i915/display: include gem/i915_gem_stolen.h where needed Jani Nikula
2024-05-31 11:03   ` Rodrigo Vivi
2024-05-31 12:03     ` Jani Nikula
2024-06-04 11:41       ` Jani Nikula
2024-06-04 20:34         ` Rodrigo Vivi
2024-05-29 17:48 ` [PATCH 02/10] drm/i915/display: include gt/intel_gt_types.h " Jani Nikula
2024-05-31 11:05   ` Rodrigo Vivi [this message]
2024-05-29 17:48 ` [PATCH 03/10] drm/i915/display: include i915_gpu_error.h " Jani Nikula
2024-05-31 11:07   ` Rodrigo Vivi
2024-05-31 11:35   ` Ville Syrjälä
2024-05-31 12:07     ` Jani Nikula
2024-05-31 12:17       ` Jani Nikula
2024-05-29 17:48 ` [PATCH 04/10] drm/i915/display: include intel_uncore.h " Jani Nikula
2024-05-31 11:07   ` Rodrigo Vivi
2024-05-29 17:48 ` [PATCH 05/10] drm/i915/display: include intel_step.h " Jani Nikula
2024-05-31 12:03   ` Rodrigo Vivi
2024-05-31 12:08     ` Jani Nikula
2024-05-29 17:48 ` [PATCH 06/10] drm/i915/display: include xe_bo.h, gem_object_types etc. " Jani Nikula
2024-05-31 12:07   ` Rodrigo Vivi
2024-05-29 17:48 ` [PATCH 07/10] drm/xe/display: move compat uncore stubs to the correct file Jani Nikula
2024-05-31 12:08   ` Rodrigo Vivi
2024-05-29 17:48 ` [PATCH 08/10] drm/xe/display: move compat runtime pm " Jani Nikula
2024-05-31 12:09   ` Rodrigo Vivi
2024-05-29 17:48 ` [PATCH 09/10] drm/xe/display: reduce includes in compat i915_drv.h Jani Nikula
2024-05-31 12:09   ` Rodrigo Vivi
2024-05-29 17:48 ` [PATCH 10/10] drm/xe/display: drop i915_drv.h include from xe code Jani Nikula
2024-05-31 12:10   ` Rodrigo Vivi
2024-05-29 18:48 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915 and drm/xe display and compat cleanups Patchwork
2024-05-29 18:48 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-29 18:56 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-30 19:38 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zlmu7iU9ofl9sodB@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox