Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: make intel_display_power_domain_str() static
Date: Thu, 15 Aug 2024 16:41:12 +0300	[thread overview]
Message-ID: <Zr4FeLoFySKebKk0@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20240815120002.3472727-1-jani.nikula@intel.com>

On Thu, Aug 15, 2024 at 03:00:02PM +0300, Jani Nikula wrote:
> The function isn't used outside of intel_display_power.c. Make it
> static.
> 
> Suggested-by: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
>  drivers/gpu/drm/i915/display/intel_display_power.h | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index cf8b38f2ebf5..39ab3117265c 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -36,7 +36,7 @@
>  	for_each_power_well_reverse(__dev_priv, __power_well)		        \
>  		for_each_if(test_bit((__domain), (__power_well)->domains.bits))
>  
> -const char *
> +static const char *
>  intel_display_power_domain_str(enum intel_display_power_domain domain)
>  {
>  	switch (domain) {
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
> index 0962f6aaeee6..425452c5a469 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> @@ -183,9 +183,6 @@ void intel_display_power_resume(struct drm_i915_private *i915);
>  void intel_display_power_set_target_dc_state(struct drm_i915_private *dev_priv,
>  					     u32 state);
>  
> -const char *
> -intel_display_power_domain_str(enum intel_display_power_domain domain);
> -
>  bool intel_display_power_is_enabled(struct drm_i915_private *dev_priv,
>  				    enum intel_display_power_domain domain);
>  intel_wakeref_t intel_display_power_get(struct drm_i915_private *dev_priv,
> -- 
> 2.39.2
> 

  parent reply	other threads:[~2024-08-15 13:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15 12:00 [PATCH] drm/i915: make intel_display_power_domain_str() static Jani Nikula
2024-08-15 12:33 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2024-08-15 12:38 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-15 13:41 ` Imre Deak [this message]
2024-08-16  9:04   ` [PATCH] " Jani Nikula
2024-08-16  8:03 ` ✗ Fi.CI.IGT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zr4FeLoFySKebKk0@ideak-desk.fi.intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox