public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Andi Shyti <andi.shyti@linux.intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Chris Wilson <chris.p.wilson@linux.intel.com>,
	Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
	Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [PATCH 0/2] Allow partial memory mapping for cpu memory
Date: Fri, 9 Aug 2024 10:53:38 +0200	[thread overview]
Message-ID: <ZrXZEpplb6YA9T_d@phenom.ffwll.local> (raw)
In-Reply-To: <20240807100521.478266-1-andi.shyti@linux.intel.com>

On Wed, Aug 07, 2024 at 11:05:19AM +0100, Andi Shyti wrote:
> Hi,
> 
> This patch series concludes on the memory mapping fixes and
> improvements by allowing partial memory mapping for the cpu
> memory as well.
> 
> The partial memory mapping by adding an object offset was
> implicitely included in commit 8bdd9ef7e9b1 ("drm/i915/gem: Fix
> Virtual Memory mapping boundaries calculation") for the gtt
> memory.

Does userspace actually care? Do we have a flag or something, so that
userspace can discover this?

Adding complexity of any kind is absolute no-go, unless there's a
userspace need. This also includes the gtt accidental fix.
-Sima

> 
> Andi
> 
> Andi Shyti (2):
>   drm/i915/gem: Do not look for the exact address in node
>   drm/i915/gem: Calculate object page offset for partial memory mapping
> 
>  drivers/gpu/drm/i915/gem/i915_gem_mman.c | 10 ++++++----
>  drivers/gpu/drm/i915/i915_mm.c           | 12 +++++++++++-
>  drivers/gpu/drm/i915/i915_mm.h           |  3 ++-
>  3 files changed, 19 insertions(+), 6 deletions(-)
> 
> -- 
> 2.45.2
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  parent reply	other threads:[~2024-08-09  8:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07 10:05 [PATCH 0/2] Allow partial memory mapping for cpu memory Andi Shyti
2024-08-07 10:05 ` [PATCH 1/2] drm/i915/gem: Do not look for the exact address in node Andi Shyti
2024-08-08 16:11   ` Nirmoy Das
2024-08-07 10:05 ` [PATCH 2/2] drm/i915/gem: Calculate object page offset for partial memory mapping Andi Shyti
2024-08-08 16:11   ` Nirmoy Das
2024-08-07 11:13 ` ✓ Fi.CI.BAT: success for Allow partial memory mapping for cpu memory Patchwork
2024-08-07 22:30 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-08-08  0:10 ` ✓ Fi.CI.BAT: success for Allow partial memory mapping for cpu memory (rev2) Patchwork
2024-08-08  7:32 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-08-09  8:53 ` Daniel Vetter [this message]
2024-08-09 10:20   ` [PATCH 0/2] Allow partial memory mapping for cpu memory Andi Shyti
2024-08-12  9:11     ` Daniel Vetter
2024-08-12 11:51       ` Andi Shyti
2024-08-12 14:45         ` Daniel Vetter
2024-08-13  2:54           ` Matthew Brost
2024-08-13 14:09             ` Daniel Vetter
2024-08-13 19:08               ` Matthew Brost
2024-08-14  2:08                 ` Matthew Brost
2024-08-19 14:17                   ` Daniel Vetter
2024-08-19 15:31                     ` Andi Shyti
2024-08-22  9:29                       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrXZEpplb6YA9T_d@phenom.ffwll.local \
    --to=daniel.vetter@ffwll.ch \
    --cc=andi.shyti@linux.intel.com \
    --cc=chris.p.wilson@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    --cc=nirmoy.das@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox