Re: [PATCH v2] drm/i915/hwmon: expose package temperature

[Raag Jadav <raag.jadav@intel.com>]

On Tue, Sep 10, 2024 at 12:27:16AM +0200, Andi Shyti wrote:
> Hi Raag,
> 
> > > > +	case hwmon_temp_input:
> > > > +		with_intel_runtime_pm(ddat->uncore->rpm, wakeref)
> > > > +			reg_val = intel_uncore_read(ddat->uncore, hwmon->rg.pkg_temp);
> > > > +
> > > > +		/* HW register value is in degrees, convert to millidegrees. */
> > > use millidegree Celsius here
> > 
> > The intent here is to signify the conversion rather than the unit.
> > But okay, will add if we have another version.
> 
> is Riana asking to improve the comment here? Then please do, if
> someone asks to make better comments it means that he is asking
> to answer to an open question that someone might have in the
> future.

To me this looks quite self documenting, but agree.

> Sending a v3 is not much of a work but improving the comment
> later is not trivial.

Already have it locally, was going to send out after you review :)

Raag