Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Hongbo Li <lihongbo22@huawei.com>
Cc: <jani.nikula@linux.intel.com>, <joonas.lahtinen@linux.intel.com>,
	<tursulin@ursulin.net>, <airlied@gmail.com>, <daniel@ffwll.ch>,
	<dri-devel@lists.freedesktop.org>,
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH -next] drm/i915: Remove extra unlikely helper
Date: Thu, 5 Sep 2024 15:44:06 -0400	[thread overview]
Message-ID: <ZtoKBhhPgZLbrz_y@intel.com> (raw)
In-Reply-To: <20240831094655.4153520-1-lihongbo22@huawei.com>

On Sat, Aug 31, 2024 at 05:46:55PM +0800, Hongbo Li wrote:
> In IS_ERR, the unlikely is used for the input parameter,
> so these is no need to use it again outside.
> 
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

and pushing now...

> ---
>  drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index 01b7587dd1f8..a3b83cfe1726 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -825,7 +825,7 @@ static int eb_select_context(struct i915_execbuffer *eb)
>  	struct i915_gem_context *ctx;
>  
>  	ctx = i915_gem_context_lookup(eb->file->driver_priv, eb->args->rsvd1);
> -	if (unlikely(IS_ERR(ctx)))
> +	if (IS_ERR(ctx))
>  		return PTR_ERR(ctx);
>  
>  	eb->gem_context = ctx;
> -- 
> 2.34.1
> 

      parent reply	other threads:[~2024-09-05 19:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-31  9:46 [PATCH -next] drm/i915: Remove extra unlikely helper Hongbo Li
2024-09-03 16:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-09-04 15:50 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-05  3:02   ` Hongbo Li
2024-09-05 19:44 ` Rodrigo Vivi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtoKBhhPgZLbrz_y@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=lihongbo22@huawei.com \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox