From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/i915/irq: Rename suspend/resume funcitons
Date: Mon, 16 Sep 2024 11:37:13 -0400 [thread overview]
Message-ID: <ZuhQqXMrTgG9xXhA@intel.com> (raw)
In-Reply-To: <rrd65omm4ldoimnilv4kcsyvjxc6rtgeiybjnh4mfl2b3lkt63@3wb3s5qpwm6k>
On Fri, Sep 13, 2024 at 11:07:33AM +0200, Andi Shyti wrote:
> Hi Rodrigo,
>
> On Thu, Sep 12, 2024 at 01:25:39PM GMT, Rodrigo Vivi wrote:
> > Although these functions are used in runtime_pm, they are not
> > exclusively used there, so remove the misleading prefix.
> >
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
>
> A general note, please add a cover letter even if the series
> looks trivial. It's important to have an overview of what the
> series does.
You are absolutely right. I'm sorry!
On a 1 or 2 patch series I don't like seeing cover letters, but
on a 3+ patches, specially on the first submission I believe it
is important.
And it helps maintainers to writing the pull-request notes later.
Thanks for the review and for the note,
Rodrigo.
>
> Thanks,
> Andi
next prev parent reply other threads:[~2024-09-16 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 17:25 [PATCH 1/3] drm/i915/irq: Remove duplicated irq_enabled variable Rodrigo Vivi
2024-09-12 17:25 ` [PATCH 2/3] drm/i915/irq: Move irqs_enabled out of runtime_pm Rodrigo Vivi
2024-09-12 20:03 ` Cavitt, Jonathan
2024-09-13 9:05 ` Andi Shyti
2024-09-12 17:25 ` [PATCH 3/3] drm/i915/irq: Rename suspend/resume funcitons Rodrigo Vivi
2024-09-12 20:21 ` Cavitt, Jonathan
2024-09-13 9:07 ` Andi Shyti
2024-09-16 15:37 ` Rodrigo Vivi [this message]
2024-09-12 19:58 ` [PATCH 1/3] drm/i915/irq: Remove duplicated irq_enabled variable Cavitt, Jonathan
2024-09-12 21:44 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/3] " Patchwork
2024-09-12 21:52 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-13 9:01 ` [PATCH 1/3] " Andi Shyti
2024-09-13 10:54 ` Jani Nikula
2024-09-13 18:12 ` ✗ Fi.CI.IGT: failure for series starting with [1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuhQqXMrTgG9xXhA@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=andi.shyti@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox