Re: [PATCH 2/2] drm/i915: Extract intel_post_plane_update_after_readout()

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Sep 19, 2024 at 10:53:15AM +0300, Luca Coelho wrote:
> On Mon, 2024-09-16 at 18:29 +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Clean up the main commit_tail() codepath a bit by pulling
> > the post plane update steps that need to performed after
> > readout into their own little function
> > (intel_post_plane_update_after_readout()).
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> 
> This looks fine, but what is the exact motivation here? Is it just to
> reduce the size of intel_atomic_commit_tail()?

That, and I guess some kind of attempt to keep the pre vs. post
update code mostly in sync (might be easier to remember to update
both sides if they are named somewhat consistently).

> 
> Regardless:
> 
> Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

Ta.

-- 
Ville Syrjälä
Intel