From: Raag Jadav <raag.jadav@intel.com>
To: Mika Kahola <mika.kahola@intel.com>
Cc: intel-gfx@lists.freedesktop.org, gustavo.sousa@intel.com,
jani.nikula@linux.intel.com
Subject: Re: [PATCH v3 0/2] drm/i915/display: Power request asserting/deasserting
Date: Thu, 31 Oct 2024 14:59:00 +0200 [thread overview]
Message-ID: <ZyN_FKqlDfQBH_24@black.fi.intel.com> (raw)
In-Reply-To: <20241031114027.225217-1-mika.kahola@intel.com>
On Thu, Oct 31, 2024 at 01:40:25PM +0200, Mika Kahola wrote:
> There is a HW issue that arises when there are race conditions
> between TCSS entering/exiting TC7 or TC10 states while the
> driver is asserting/deasserting TCSS power request. As a
> workaround, Display driver will implement a mailbox sequence
> to ensure that the TCSS is in TC0 when TCSS power request is
> asserted/deasserted.
>
> The sequence is the following
>
> 1. Read mailbox command status and wait until run/busy bit is
> clear
> 2. Write mailbox data value '1' for power request asserting
> and '0' for power request deasserting
> 3. Write mailbox command run/busy bit and command value with 0x1
> 4. Read mailbox command and wait until run/busy bit is clear
> before continuing power request.
>
> while at it, let's start using struct intel_display instead of
> struct drm_i915_private as well.
Perhaps this needs to be its own patch since it's unrelated to the series.
Raag
next prev parent reply other threads:[~2024-10-31 12:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 11:40 [PATCH v3 0/2] drm/i915/display: Power request asserting/deasserting Mika Kahola
2024-10-31 11:40 ` [PATCH v3 1/2] drm/i915/xe3lpd: " Mika Kahola
2024-10-31 12:55 ` Raag Jadav
2024-10-31 14:29 ` Kahola, Mika
2024-10-31 14:50 ` Raag Jadav
2024-10-31 15:12 ` Raag Jadav
2024-11-01 11:47 ` Kahola, Mika
2024-10-31 11:40 ` [PATCH v3 2/2] drm/i915/display: Use struct intel_display instead of struct drm_i915_private Mika Kahola
2024-10-31 12:50 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Power request asserting/deasserting Patchwork
2024-10-31 12:50 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-10-31 12:59 ` Raag Jadav [this message]
2024-10-31 14:28 ` [PATCH v3 0/2] " Kahola, Mika
2024-10-31 14:55 ` Raag Jadav
2024-10-31 14:04 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyN_FKqlDfQBH_24@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox