Re: [PATCH v2] drm/i915: Fixed NULL pointer dereference in capture_engine

[Andi Shyti <andi.shyti@linux.intel.com>]

Hi Eugene,

On Wed, Nov 20, 2024 at 03:03:29PM +0000, Eugene Kobyak wrote:
> When the intel_context structure contains NULL,
> it raises a NULL pointer dereference error in drm_info().
> 
> This patch aims to resolve issue:
> https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12309
> 
> Signed-off-by: Eugene Kobyak <eugene.kobyak@intel.com>

Looks better, but you forgot:

Fixes: e8a3319c31a1 ("drm/i915: Allow error capture without a request")
Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12309
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: <stable@vger.kernel.org> # v6.3+

(Note the second line, Closes, this is how the gitlab issue
should be reported).

No worries, if John doesn't have anything agains, I can fix it.

But I was actually thinking here that the guc_id can be also
taken from engine->guc_id, I think it's the same.

Andi