From: "Kahola, Mika" <mika.kahola@intel.com>
To: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Deak, Imre" <imre.deak@intel.com>
Subject: Re: [PATCH] drm/i915/icl: More workaround for port F detection due to broken VBTs
Date: Mon, 13 May 2019 12:47:43 +0000 [thread overview]
Message-ID: <a2c771a90d95873afe70f4d1f4731db98c8f70c2.camel@intel.com> (raw)
In-Reply-To: <20190510140255.25215-1-imre.deak@intel.com>
This fixes the issue on my ICL-Y.
On Fri, 2019-05-10 at 17:02 +0300, Imre Deak wrote:
> Add another ICL-Y PCIID that proved to have only 5 ports to the
> corresponding PCIID list.
>
> Meanwhile I'm trying to get a complete list of all PCIIDs with less
> than
> 6 ports and/or get a VBT fix to mark these ports non-existant, but
> until
> then the only way is to go one-by-one.
>
> This fixes the following error on machines with less than 6 port:
>
> [drm:intel_power_well_enable [i915]] enabling AUX F
> ------------[ cut here ]------------
> WARN_ON(intel_wait_for_register(&dev_priv->uncore, regs-
> >driver, (0x1 << ((pw_idx) * 2)), (0x1 << ((pw_idx) * 2)), 1))
>
> (Internal reference: BSpec/Index/20584/Issues, HSD/1306084116)
>
> Cc: Mika Kahola <mika.kahola@intel.com>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=108915
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
> ---
> include/drm/i915_pciids.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 6477da22af28..6d60ea68c171 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -559,7 +559,6 @@
> #define INTEL_ICL_PORT_F_IDS(info) \
> INTEL_VGA_DEVICE(0x8A50, info), \
> INTEL_VGA_DEVICE(0x8A5C, info), \
> - INTEL_VGA_DEVICE(0x8A5D, info), \
> INTEL_VGA_DEVICE(0x8A59, info), \
> INTEL_VGA_DEVICE(0x8A58, info), \
> INTEL_VGA_DEVICE(0x8A52, info), \
> @@ -573,7 +572,8 @@
>
> #define INTEL_ICL_11_IDS(info) \
> INTEL_ICL_PORT_F_IDS(info), \
> - INTEL_VGA_DEVICE(0x8A51, info)
> + INTEL_VGA_DEVICE(0x8A51, info), \
> + INTEL_VGA_DEVICE(0x8A5D, info)
>
> /* EHL */
> #define INTEL_EHL_IDS(info) \
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-05-13 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 14:02 [PATCH] drm/i915/icl: More workaround for port F detection due to broken VBTs Imre Deak
2019-05-10 14:36 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-05-10 15:09 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-10 17:34 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-14 10:55 ` Imre Deak
2019-05-13 12:47 ` Kahola, Mika [this message]
2019-05-13 13:56 ` [PATCH] " Jani Nikula
2019-05-13 14:05 ` Imre Deak
2019-05-14 7:51 ` Jani Nikula
2019-05-14 9:37 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2c771a90d95873afe70f4d1f4731db98c8f70c2.camel@intel.com \
--to=mika.kahola@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox