From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Only trust sseu subslice fuse if it is set
Date: Sat, 30 Jan 2021 14:42:12 +0200 [thread overview]
Message-ID: <a4086b6d-6a97-ba97-cbaa-86cd6ce9f0c0@intel.com> (raw)
In-Reply-To: <20210129124640.15048-1-chris@chris-wilson.co.uk>
On 29/01/2021 14:46, Chris Wilson wrote:
> Since userspace cannot run without any subslices, it seems remarkable
> that any system would be configured with all fused off. Ignore the fuse
> register if it says 0.
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/3022
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/gt/intel_sseu.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.c b/drivers/gpu/drm/i915/gt/intel_sseu.c
> index 0d9f74aec8fe..99c992db2ce7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_sseu.c
> +++ b/drivers/gpu/drm/i915/gt/intel_sseu.c
> @@ -341,9 +341,10 @@ static void gen9_sseu_info_init(struct intel_gt *gt)
> * The subslice disable field is global, i.e. it applies
> * to each of the enabled slices.
> */
> - subslice_mask = (1 << sseu->max_subslices) - 1;
> - subslice_mask &= ~((fuse2 & GEN9_F2_SS_DIS_MASK) >>
> - GEN9_F2_SS_DIS_SHIFT);
> + subslice_mask = (fuse2 & GEN9_F2_SS_DIS_MASK) >> GEN9_F2_SS_DIS_SHIFT;
> + if (!subslice_mask) /* Ignore the fuse if it says there is no HW */
> + subslice_mask = ~0u;
> + subslice_mask &= GENMASK(sseu->max_subslices - 1, 0);
>
> /*
> * Iterate through enabled slices and subslices to
I'm afraid it's not enough, as far as I can tell even the slice_mask is
wrong (user device is GT2, can't have 3 slices).
Time to reach out to HW folks.
-Lionel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-01-30 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 12:46 [Intel-gfx] [PATCH] drm/i915/gt: Only trust sseu subslice fuse if it is set Chris Wilson
2021-01-29 13:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2021-01-30 12:42 ` Lionel Landwerlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4086b6d-6a97-ba97-cbaa-86cd6ce9f0c0@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox