From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tursulin@ursulin.net>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [RFC 3/6] drm/i915: Give our log messages our name
Date: Tue, 30 Jan 2018 10:53:14 +0000 [thread overview]
Message-ID: <a44f9123-3d79-3427-b786-25a018e46ac4@linux.intel.com> (raw)
In-Reply-To: <op.zdf9jpf7xaggs7@mwajdecz-mobl1.ger.corp.intel.com>
On 26/01/2018 13:10, Michal Wajdeczko wrote:
> On Wed, 24 Jan 2018 17:18:18 +0100, Tvrtko Ursulin
> <tursulin@ursulin.net> wrote:
>
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Define DRM_LOG_NAME to i915 so that the log messages we output change
>> from:
>>
>> [drm] RC6 on
>>
>> to:
>>
>> [i915] RC6 on
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: dri-devel@lists.freedesktop.org
>> ---
>> drivers/gpu/drm/i915/i915_drv.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h
>> b/drivers/gpu/drm/i915/i915_drv.h
>> index 8333692dac5a..2b48a7d2d129 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -30,6 +30,11 @@
>> #ifndef _I915_DRV_H_
>> #define _I915_DRV_H_
>> +#ifdef DRM_LOG_NAME
>> +#undef DRM_LOG_NAME
>> +#endif
>> +#define DRM_LOG_NAME "i915"
>
> Maybe better option would be to add this definition to our Makefile
>
> subdir-ccflags-y += -DDRM_LOG_NAME=\"i915\"
>
> Note that drm_print.h (patch 2/6) already has proper #ifndef
So that is always guaranteed to be included first? Sounds attractive, yep.
Unfortunately series does not seem to improve things sufficiently to
garner any interest so I am reluctant to respin with that change.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-30 10:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 16:18 [RFC v2 0/6] DRM logging tidy Tvrtko Ursulin
2018-01-24 16:18 ` [RFC 1/6] drm/armada: Simplify drm_dev_init error log Tvrtko Ursulin
2018-01-24 17:44 ` Russell King - ARM Linux
2018-01-24 16:18 ` [RFC 2/6] drm: Introduce unexported DRM_LOG_NAME define for logging Tvrtko Ursulin
2018-01-24 16:18 ` [RFC 3/6] drm/i915: Give our log messages our name Tvrtko Ursulin
2018-01-26 13:10 ` [Intel-gfx] " Michal Wajdeczko
2018-01-30 10:53 ` Tvrtko Ursulin [this message]
2018-01-24 16:18 ` [RFC 4/6] drm: Respect driver set DRM_LOG_NAME in drm_printk Tvrtko Ursulin
2018-01-24 16:18 ` [RFC 5/6] drm: Respect driver set DRM_LOG_NAME in drm_dev_printk Tvrtko Ursulin
2018-01-24 16:18 ` [RFC 6/6] drm: Respect driver set DRM_LOG_NAME in drm_info_printer Tvrtko Ursulin
2018-01-24 16:23 ` [Intel-gfx] [RFC v2 0/6] DRM logging tidy Chris Wilson
2018-01-24 16:48 ` Tvrtko Ursulin
2018-01-25 11:32 ` Jani Nikula
2018-01-25 13:38 ` [Intel-gfx] " Tvrtko Ursulin
2018-01-24 16:42 ` ✓ Fi.CI.BAT: success for DRM logging tidy (rev2) Patchwork
2018-01-24 20:12 ` ✗ Fi.CI.IGT: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a44f9123-3d79-3427-b786-25a018e46ac4@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox