Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Manna, Animesh" <animesh.manna@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Murthy, Arun R" <arun.r.murthy@intel.com>,
	"Nikula, Jani" <jani.nikula@intel.com>,
	"Deak, Imre" <imre.deak@intel.com>
Subject: Re: [PATCH v8 2/3] drm/i915/display: Add hook to check optimization support for Intel platforms
Date: Mon, 23 Mar 2026 13:13:05 +0000	[thread overview]
Message-ID: <a583e5c76b0569111442005062d39f8a9db72cdb.camel@intel.com> (raw)
In-Reply-To: <c7a00eac4f5fc2d606db15d631c0ceb2b769edd4.camel@intel.com>

On Mon, 2026-03-23 at 15:04 +0200, Hogander, Jouni wrote:
> On Wed, 2026-03-18 at 14:26 +0530, Animesh Manna wrote:
> > Add a hook that uses the drm core tunneling function to check
> > whether panel replay bandwidth optimization support is present.
> > 
> > v2: Move DISPLAY_VER() check to
> > intel_dp_tunnel_pr_optimization_supported(). [Jouni]
> > 
> > Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> 
> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> 
> > ---
> >  drivers/gpu/drm/i915/display/intel_dp_tunnel.c | 18
> > ++++++++++++++++++
> >  drivers/gpu/drm/i915/display/intel_dp_tunnel.h |  6 ++++++
> >  2 files changed, 24 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_tunnel.c
> > b/drivers/gpu/drm/i915/display/intel_dp_tunnel.c
> > index 1fd1ac8d556d..b81ac9a2d727 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_tunnel.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_tunnel.c
> > @@ -296,6 +296,24 @@ bool
> > intel_dp_tunnel_bw_alloc_is_enabled(struct
> > intel_dp *intel_dp)
> >  	return drm_dp_tunnel_bw_alloc_is_enabled(intel_dp-
> > >tunnel);
> >  }
> >  
> > +/**
> > + * intel_dp_tunnel_pr_optimization_supported - Query the PR BW
> > optimization support
> > + * @intel_dp: DP port object
> > + *
> > + * Query whether a DP tunnel supports the PR BW optimization.
> > + *
> > + * Returns %true if the BW allocation mode is supported on
> > @intel_dp.
> > + */
> > +bool intel_dp_tunnel_pr_optimization_supported(struct intel_dp
> > *intel_dp)
> > +{
> > +	struct intel_display *display =
> > to_intel_display(intel_dp);
> > +
> > +	if (DISPLAY_VER(display) < 35)
> > +		return false;

Just noticed in Bspec that this is actually supported already on
DISPLAY_VER() == 30.

BR,
Jouni Högander

> > +
> > +	return drm_dp_tunnel_pr_optimization_supported(intel_dp-
> > > tunnel);
> > +}
> > +
> >  /**
> >   * intel_dp_tunnel_suspend - Suspend a DP tunnel connected on a
> > port
> >   * @intel_dp: DP port object
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_tunnel.h
> > b/drivers/gpu/drm/i915/display/intel_dp_tunnel.h
> > index 7f0f720e8dca..03e147736b65 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_tunnel.h
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_tunnel.h
> > @@ -32,6 +32,7 @@ void intel_dp_tunnel_resume(struct intel_dp
> > *intel_dp,
> >  void intel_dp_tunnel_suspend(struct intel_dp *intel_dp);
> >  
> >  bool intel_dp_tunnel_bw_alloc_is_enabled(struct intel_dp
> > *intel_dp);
> > +bool intel_dp_tunnel_pr_optimization_supported(struct intel_dp
> > *intel_dp);
> >  
> >  void
> >  intel_dp_tunnel_atomic_cleanup_inherited_state(struct
> > intel_atomic_state *state);
> > @@ -76,6 +77,11 @@ static inline bool
> > intel_dp_tunnel_bw_alloc_is_enabled(struct intel_dp *intel_dp
> >  	return false;
> >  }
> >  
> > +static inline bool
> > intel_dp_tunnel_pr_optimization_supported(struct
> > intel_dp *intel_dp)
> > +{
> > +	return false;
> > +}
> > +
> >  static inline void
> >  intel_dp_tunnel_atomic_cleanup_inherited_state(struct
> > intel_atomic_state *state) {}
> >  
> 


  reply	other threads:[~2026-03-23 13:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18  8:56 [PATCH v8 0/3] Panel Replay BW optimization Animesh Manna
2026-03-18  8:56 ` [PATCH v8 1/3] drm/i915/display: Add drm helper to check pr optimization support Animesh Manna
2026-03-23 13:02   ` Hogander, Jouni
2026-03-18  8:56 ` [PATCH v8 2/3] drm/i915/display: Add hook to check optimization support for Intel platforms Animesh Manna
2026-03-23 13:04   ` Hogander, Jouni
2026-03-23 13:13     ` Hogander, Jouni [this message]
2026-03-24  8:36       ` Manna, Animesh
2026-03-18  8:56 ` [PATCH v8 3/3] drm/i915/display: Panel Replay BW optimization for DP2.0 tunneling Animesh Manna
2026-03-23 13:27   ` Hogander, Jouni
2026-03-18 10:31 ` ✓ i915.CI.BAT: success for Panel Replay BW optimization (rev2) Patchwork
2026-03-19 14:07 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a583e5c76b0569111442005062d39f8a9db72cdb.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox