From: Thomas Zimmermann <tzimmermann@suse.de>
To: Jani Nikula <jani.nikula@intel.com>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 2/2] drm/debugfs: also take per device driver features into account
Date: Wed, 22 Jan 2020 17:11:51 +0100 [thread overview]
Message-ID: <a71522fa-780d-1c09-17dc-46230967223f@suse.de> (raw)
In-Reply-To: <20200122155030.29304-2-jani.nikula@intel.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1445 bytes --]
Hi
Am 22.01.20 um 16:50 schrieb Jani Nikula:
> Use drm_core_check_all_features() to ensure both the driver features and
> the per-device driver features are taken into account when registering
> debugfs files.
>
> v2:
> - use drm_core_check_all_features()
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/drm_debugfs.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index eab0f2687cd6..0c70b4b22c8a 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -180,10 +180,7 @@ int drm_debugfs_create_files(const struct drm_info_list *files, int count,
> int i;
>
> for (i = 0; i < count; i++) {
> - u32 features = files[i].driver_features;
> -
> - if (features != 0 &&
> - (dev->driver->driver_features & features) != features)
> + if (!drm_core_check_all_features(dev, files[i].driver_features))
> continue;
>
> tmp = kmalloc(sizeof(struct drm_info_node), GFP_KERNEL);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-22 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 15:50 [Intel-gfx] [PATCH v3 1/2] drm: add drm_core_check_all_features() to check for a mask of features Jani Nikula
2020-01-22 15:50 ` [Intel-gfx] [PATCH v3 2/2] drm/debugfs: also take per device driver features into account Jani Nikula
2020-01-22 16:11 ` Thomas Zimmermann [this message]
2020-01-23 13:01 ` Jani Nikula
2020-01-22 16:11 ` [Intel-gfx] [PATCH v3 1/2] drm: add drm_core_check_all_features() to check for a mask of features Thomas Zimmermann
2020-01-22 22:04 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/2] " Patchwork
2020-01-23 11:45 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/2] drm: add drm_core_check_all_features() to check for a mask of features (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a71522fa-780d-1c09-17dc-46230967223f@suse.de \
--to=tzimmermann@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox