From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915/icl: Disable master intr before reading
Date: Mon, 15 Oct 2018 10:41:56 -0700 [thread overview]
Message-ID: <a888a9f0-e3af-9d2f-39c5-a6a8201b4ffe@intel.com> (raw)
In-Reply-To: <20181015141440.21845-3-mika.kuoppala@linux.intel.com>
On 15/10/18 07:14, Mika Kuoppala wrote:
> Disable master interrupt before reading level indications.
> This will close a race where we get a level indication between
> reading and disabling, generating an extra interrupt where we
> could have avoided one.
>
> Further, as the reading acts also as a post, replace the
> write/post on the irq reset with the helper. On enabling side,
> posting doesn't serve any purpose so it can also be replaced
> with helper.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Daniele
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-15 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 14:14 [PATCH 1/3] drm/i915/gen8: Disable master intr before reading Mika Kuoppala
2018-10-15 14:14 ` [PATCH 2/3] drm/i915/icl: No need to ack intr through master control Mika Kuoppala
2018-10-15 14:14 ` [PATCH 3/3] drm/i915/icl: Disable master intr before reading Mika Kuoppala
2018-10-15 17:41 ` Daniele Ceraolo Spurio [this message]
2018-10-16 10:39 ` Mika Kuoppala
2018-10-15 14:41 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/gen8: " Patchwork
2018-10-15 17:53 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a888a9f0-e3af-9d2f-39c5-a6a8201b4ffe@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox