public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jonathan Gray <jsg@jsg.id.au>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/pxp: fix non-optimised !CONFIG_DRM_I915_PXP build
Date: Wed, 7 May 2025 00:45:07 +1000	[thread overview]
Message-ID: <aBogc_3nH8ej_M_h@largo.jsg.id.au> (raw)
In-Reply-To: <87wmatvqj6.fsf@intel.com>

On Tue, May 06, 2025 at 04:04:45PM +0300, Jani Nikula wrote:
> On Tue, 06 May 2025, Jonathan Gray <jsg@jsg.id.au> wrote:
> > On Tue, Nov 05, 2024 at 11:23:36AM +0200, Jani Nikula wrote:
> >> On Sun, 03 Nov 2024, Jonathan Gray <jsg@jsg.id.au> wrote:
> >> > intel_pxp_gsccs_is_ready_for_sessions() is gated by CONFIG_DRM_I915_PXP
> >> > but called from intel_pxp.c which isn't.  Provide a fallback inline
> >> > function to fix the non-optimised build.
> >> >
> >> > Fixes: 99afb7cc8c44 ("drm/i915/pxp: Add ARB session creation and cleanup")
> >> > Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
> >> 
> >> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> >
> > equivalent patch was merged and now queued for stable
> > 7e21ea8149a0 ("drm/i915/pxp: fix undefined reference to `intel_pxp_gsccs_is_ready_for_sessions'")
> 
> Oh, damn. I'm really sorry for first dropping the ball on your patch,
> and then encountering another patch and forgetting one like that already
> existed.
> 
> My bad, apologies.

Thanks.  I mentioned this in case someone with the same problem found
this thread.  I understand you have many patches to keep track of.

      reply	other threads:[~2025-05-06 14:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-03 11:02 [PATCH] drm/i915/pxp: fix non-optimised !CONFIG_DRM_I915_PXP build Jonathan Gray
2024-11-04 10:16 ` Jani Nikula
2024-11-04 11:44   ` Jonathan Gray
2024-11-04 13:40     ` Jani Nikula
2024-11-04 14:20 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-11-05  1:35 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-05  9:23 ` [PATCH] " Jani Nikula
2025-05-06 12:42   ` Jonathan Gray
2025-05-06 13:04     ` Jani Nikula
2025-05-06 14:45       ` Jonathan Gray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBogc_3nH8ej_M_h@largo.jsg.id.au \
    --to=jsg@jsg.id.au \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox