Re: [PATCH 00/16] drm/i915/display: make all global state opaque

[Imre Deak <imre.deak@intel.com>]

On Thu, Jun 12, 2025 at 03:11:55PM +0300, Jani Nikula wrote:
> Hide all the structs that "derive" from struct intel_global_state inside
> their respective implementation files.

On the patchset:
Reviewed-by: Imre Deak <imre.deak@intel.com>

A nit later about naming of functions.

> Jani Nikula (16):
>   drm/i915/wm: abstract intel_dbuf_pmdemand_needs_update()
>   drm/i915/wm: add more accessors to dbuf state
>   drm/i915/wm: make struct intel_dbuf_state opaque type
>   drm/i915/bw: abstract intel_bw_pmdemand_needs_update()
>   drm/i915/bw: relocate intel_can_enable_sagv() and rename to
>     intel_bw_can_enable_sagv()
>   drm/i915: move icl_sagv_{pre,post}_plane_update() to intel_bw.c
>   drm/i915/bw: abstract intel_bw_qgv_point_peakbw()
>   drm/i915/bw: make struct intel_bw_state opaque
>   drm/i915/cdclk: abstract intel_cdclk_logical()
>   drm/i915/cdclk: abstract intel_cdclk_min_cdclk()
>   drm/i915/cdclk: abstract intel_cdclk_bw_min_cdclk()
>   drm/i915/cdclk: abstract intel_cdclk_pmdemand_needs_update()
>   drm/i915/cdclk: abstract intel_cdclk_force_min_cdclk()
>   drm/i915/cdclk: abstract intel_cdclk_read_hw()
>   drm/i915/cdclk: abstract intel_cdclk_actual() and
>     intel_cdclk_actual_voltage_level()
>   drm/i915/cdclk: make struct intel_cdclk_state opaque
> 
>  drivers/gpu/drm/i915/display/hsw_ips.c        |   2 +-
>  .../gpu/drm/i915/display/intel_atomic_plane.c |   4 +-
>  drivers/gpu/drm/i915/display/intel_audio.c    |   2 +-
>  drivers/gpu/drm/i915/display/intel_bw.c       | 153 ++++++++++++++++--
>  drivers/gpu/drm/i915/display/intel_bw.h       |  53 ++----
>  drivers/gpu/drm/i915/display/intel_cdclk.c    |  93 +++++++++++
>  drivers/gpu/drm/i915/display/intel_cdclk.h    |  50 ++----
>  drivers/gpu/drm/i915/display/intel_display.c  |   2 +-
>  .../drm/i915/display/intel_display_driver.c   |   8 +-
>  drivers/gpu/drm/i915/display/intel_fbc.c      |   2 +-
>  drivers/gpu/drm/i915/display/intel_pmdemand.c |  41 ++---
>  drivers/gpu/drm/i915/display/skl_watermark.c  | 134 +++++++--------
>  drivers/gpu/drm/i915/display/skl_watermark.h  |  33 +---
>  13 files changed, 336 insertions(+), 241 deletions(-)
> 
> -- 
> 2.39.5
>